Ensure dev server side errors are correct #28520

ijjk · 2021-08-26T04:08:34Z

This updates server-side errors shown in the terminal to resolve the stack trace and show accurate line/columns and related source code similar to how we do in the dev overlay. This also updates to trigger the dev overlay when an error occurred in an API route and dismisses the overlay after the error as been fixed.

Examples:

before: `getServerSideProps` error

after: `getServerSideProps` error

before: API route error

after: API route error

before: uncaught rejection/exception

after: uncaught rejection/exception

Fixes: #26711
Fixes: #21904

sokra · 2021-08-26T10:14:39Z

packages/next/server/dev/next-dev-server.ts

+        let usedOriginalStack = false
+        try {
+          const frames = parseStack(err.stack)
+          const frame = frames[0]


I guess we should remap all frames

Is showing the other frames helpful usually? We collapse all but the first in the dev overlay

sokra

catching rejected Promises might also be a good idea

ijjk · 2021-08-26T14:51:01Z

Added catching of unhandled rejections/exceptions as well, good idea!

…de-errors # Conflicts: # packages/next/server/render.tsx

ijjk · 2021-08-26T16:14:19Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js fix/dev-server-side-errors	Change
buildDuration	15.8s	16s	⚠️ +213ms
buildDurationCached	3.8s	3.7s	-153ms
nodeModulesSize	61.7 MB	61.7 MB	⚠️ +11.8 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js fix/dev-server-side-errors	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.016	2.907	-0.11
/ avg req/sec	828.82	859.96	+31.14
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.924	1.856	-0.07
/error-in-render avg req/sec	1299.47	1346.62	+47.15

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js fix/dev-server-side-errors	Change
745.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	23.3 kB	23.3 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	67.2 kB	67.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/dev-server-side-errors	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/dev-server-side-errors	Change
_app-HASH.js gzip	979 B	979 B	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	329 B	329 B	✓
dynamic-HASH.js gzip	2.67 kB	2.67 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	918 B	918 B	✓
image-HASH.js gzip	4.14 kB	4.14 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	318 B	318 B	✓
script-HASH.js gzip	387 B	387 B	✓
withRouter-HASH.js gzip	320 B	320 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	13 kB	13 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/dev-server-side-errors	Change
_buildManifest.js gzip	491 B	491 B	✓
Overall change	491 B	491 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js fix/dev-server-side-errors	Change
index.html gzip	541 B	541 B	✓
link.html gzip	552 B	552 B	✓
withRouter.html gzip	534 B	534 B	✓
Overall change	1.63 kB	1.63 kB	✓

Webpack 4 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js fix/dev-server-side-errors	Change
buildDuration	13.7s	13.5s	-154ms
buildDurationCached	5.7s	5.6s	-69ms
nodeModulesSize	61.7 MB	61.7 MB	⚠️ +11.8 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js fix/dev-server-side-errors	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.016	2.988	-0.03
/ avg req/sec	829.02	836.58	+7.56
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.909	1.869	-0.04
/error-in-render avg req/sec	1309.33	1337.38	+28.05

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js fix/dev-server-side-errors	Change
16.HASH.js gzip	186 B	186 B	✓
677f882d2ed8..HASH.js gzip	14.1 kB	14.1 kB	✓
framework.HASH.js gzip	41.9 kB	41.9 kB	✓
main-HASH.js gzip	10.7 kB	10.7 kB	✓
webpack-HASH.js gzip	1.19 kB	1.19 kB	✓
Overall change	68.1 kB	68.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/dev-server-side-errors	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/dev-server-side-errors	Change
_app-HASH.js gzip	964 B	964 B	✓
_error-HASH.js gzip	3.8 kB	3.8 kB	✓
amp-HASH.js gzip	552 B	552 B	✓
css-HASH.js gzip	333 B	333 B	✓
dynamic-HASH.js gzip	2.87 kB	2.87 kB	✓
head-HASH.js gzip	3.06 kB	3.06 kB	✓
hooks-HASH.js gzip	924 B	924 B	✓
index-HASH.js gzip	231 B	231 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	298 B	298 B	✓
script-HASH.js gzip	3.03 kB	3.03 kB	✓
withRouter-HASH.js gzip	295 B	295 B	✓
30809af5c834..565.css gzip	125 B	125 B	✓
Overall change	18.1 kB	18.1 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/dev-server-side-errors	Change
_buildManifest.js gzip	500 B	500 B	✓
Overall change	500 B	500 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js fix/dev-server-side-errors	Change
index.html gzip	584 B	584 B	✓
link.html gzip	597 B	597 B	✓
withRouter.html gzip	578 B	578 B	✓
Overall change	1.76 kB	1.76 kB	✓

Commit: 3efc5c8

Ensure dev server side errors are correct

5727684

ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Aug 26, 2021

undo un-needed type change

7f57d40

This comment has been minimized.

Sign in to view

Update test and isFile check

4f6b982

This comment has been minimized.

Sign in to view

ijjk marked this pull request as ready for review August 26, 2021 05:29

ijjk requested review from huozhi, padmaia, shuding, styfle and timneutkens as code owners August 26, 2021 05:29

sokra requested changes Aug 26, 2021

View reviewed changes

ijjk added 2 commits August 26, 2021 09:00

Update render to use ErrorDebug still

56728a9

correct errors for unhandled rejection/exception as well

8dbfaf0

This comment has been minimized.

Sign in to view

ensure type is passed

a6c31b6

ijjk requested a review from sokra August 26, 2021 14:51

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'upstream/canary' into fix/dev-server-si…

3e6d10e

…de-errors # Conflicts: # packages/next/server/render.tsx

This comment has been minimized.

Sign in to view

bump

3efc5c8

timneutkens approved these changes Aug 27, 2021

View reviewed changes

timneutkens merged commit f1dbc92 into vercel:canary Aug 27, 2021

timneutkens deleted the fix/dev-server-side-errors branch August 27, 2021 12:29

snyk-bot mentioned this pull request Aug 31, 2021

[Snyk] Security upgrade next from 10.2.3 to 11.1.1 majacQ/next.js#210

Open

snyk-bot mentioned this pull request Sep 19, 2021

[Snyk] Security upgrade next from 10.2.3 to 11.1.1 majacQ/next.js#286

Open

This was referenced Dec 11, 2021

[Snyk] Security upgrade next from 11.1.0 to 11.1.3 MaxMood96/next.js#208

Open

[Snyk] Security upgrade next from 11.1.0 to 11.1.3 orysmudi/next.js#20

Open

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure dev server side errors are correct #28520

Ensure dev server side errors are correct #28520

ijjk commented Aug 26, 2021 •

edited

This comment has been minimized.

This comment has been minimized.

sokra Aug 26, 2021

ijjk Aug 26, 2021

sokra left a comment

This comment has been minimized.

ijjk commented Aug 26, 2021

This comment has been minimized.

This comment has been minimized.

ijjk commented Aug 26, 2021

Ensure dev server side errors are correct #28520

Ensure dev server side errors are correct #28520

Conversation

ijjk commented Aug 26, 2021 • edited

This comment has been minimized.

This comment has been minimized.

sokra Aug 26, 2021

Choose a reason for hiding this comment

ijjk Aug 26, 2021

Choose a reason for hiding this comment

sokra left a comment

Choose a reason for hiding this comment

This comment has been minimized.

ijjk commented Aug 26, 2021

This comment has been minimized.

This comment has been minimized.

ijjk commented Aug 26, 2021

Stats from current PR

ijjk commented Aug 26, 2021 •

edited