Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicating script component when using rewrite rule in config.next.js #28538

Closed
zt1983811 opened this issue Aug 26, 2021 · 7 comments
Closed
Labels
bug Issue was opened via the bug report template. please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity

Comments

@zt1983811
Copy link

zt1983811 commented Aug 26, 2021

What example does this report relate to?

next/script + rewrite rule

What version of Next.js are you using?

11.1.0

What version of Node.js are you using?

15.7.0

What browser are you using?

Chrome

What operating system are you using?

Macos/Linux

How are you deploying your application?

use codesandbox https://codesandbox.io/s/old-flower-wx1zm?file=/next.config.js

Describe the Bug

I see 2 times of script being generated by next/script when I have rewrites rule in next.config.js

Check following screenshot you have script with console.log 2 times being generated:
image

Please see the detail in codesandbox:
https://codesandbox.io/s/old-flower-wx1zm

Expected Behavior

only one script suppose be generated.

To Reproduce

  • add script in either _app.js or and pages component by next/script ie: in _app.js
import Script from "next/script";

function MyApp({ Component, pageProps }) {
  return (
    <>
      <Component {...pageProps} />
      <Script>console.log("this is duplicated")</Script>;
    </>
  );
}
export default MyApp;
  • create whatever rewrites rule in next.config.js
module.exports = {
  async rewrites() {
    return [
      {
        source: "/about",
        destination: "/"
      }
    ];
  }
};
  • Run page if script
    and search for script tag
@zt1983811 zt1983811 added bug Issue was opened via the bug report template. examples Issue/PR related to examples labels Aug 26, 2021
@jflheureux
Copy link

I believe this is fixed in #28428 and released in next.js 11.1.1. An upgrade from 11.0.0 to 11.1.2 fixed the issue for me.

@zt1983811
Copy link
Author

@jflayhart could you check my codesandbox example please? It's already 11.1.2 but there is still duplicated script component.

image
image

@jflheureux
Copy link

jflheureux commented Sep 18, 2021 via email

@zt1983811
Copy link
Author

@jflheureux Ah ok I see, after adding id it's not duplicated. However, it's still strange when I need to put id to avoid duplication.....

Thank you

@jankaifer jankaifer added please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity and removed examples Issue/PR related to examples labels Nov 30, 2022
@github-actions
Copy link
Contributor

We cannot recreate the issue with the provided information. Please add a reproduction in order for us to be able to investigate.

Why was this issue marked with the please add a complete reproduction label?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We prefer a link to a public GitHub repository (template), but you can also use a tool like CodeSandbox or StackBlitz.

To make sure the issue is resolved as quickly as possible, please make sure that the reproduction is as minimal as possible. This means that you should remove unnecessary code, files, and dependencies that do not contribute to the issue.

Please test your reproduction against the latest version of Next.js (next@canary) to make sure your issue has not already been fixed.

I added a link, why was it still marked?

Ensure the link is pointing to a codebase that is accessible (e.g. not a private repository). "example.com", "n/a", "will add later", etc. are not acceptable links -- we need to see a public codebase. See the above section for accepted links.

What happens if I don't provide a sufficient minimal reproduction?

Issues with the please add a complete reproduction label that receives no meaningful activity (e.g. new comments with a reproduction link) are automatically closed and locked after 30 days.

If your issue has not been resolved in that time and it has been closed/locked, please open a new issue with the required reproduction.

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps. Furthermore, you can upvote the issue using the 👍 reaction on the topmost comment (please do not comment "I have the same issue" without repro steps). Then, we can sort issues by votes to prioritize.

I think my reproduction is good enough, why aren't you looking into it quicker?

We look into every Next.js issue and constantly monitor open issues for new comments.

However, sometimes we might miss one or two due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources

@balazsorban44
Copy link
Member

This issue has been automatically closed because it wasn't verified against next@canary. If you think it was closed by accident, please leave a comment. If you are running into a similar issue, please open a new issue with a reproduction. Thank you.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template. please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity
Projects
None yet
Development

No branches or pull requests

4 participants