Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure build trace handles mixed modules #28770

Merged
merged 1 commit into from Sep 3, 2021
Merged

Ensure build trace handles mixed modules #28770

merged 1 commit into from Sep 3, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Sep 3, 2021

Follow-up to #28667 this ensures we handle mixed import/require cases in the experimental nftTracing mode.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Sep 3, 2021
@ijjk
Copy link
Member Author

ijjk commented Sep 3, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js tracing/mixed-modules Change
buildDuration 11.8s 11.9s ⚠️ +37ms
buildDurationCached 3.1s 3.1s ⚠️ +3ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +107 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js tracing/mixed-modules Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.315 2.343 ⚠️ +0.03
/ avg req/sec 1080.02 1066.97 ⚠️ -13.05
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.291 1.264 -0.03
/error-in-render avg req/sec 1935.79 1977.46 +41.67
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js tracing/mixed-modules Change
745.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 23.3 kB 23.3 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 67.2 kB 67.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js tracing/mixed-modules Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js tracing/mixed-modules Change
_app-HASH.js gzip 979 B 979 B ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 329 B 329 B ✓
dynamic-HASH.js gzip 2.67 kB 2.67 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 918 B 918 B ✓
image-HASH.js gzip 4.14 kB 4.14 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 318 B 318 B ✓
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 13 kB 13 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js tracing/mixed-modules Change
_buildManifest.js gzip 492 B 492 B ✓
Overall change 492 B 492 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js tracing/mixed-modules Change
index.html gzip 541 B 541 B ✓
link.html gzip 553 B 553 B ✓
withRouter.html gzip 533 B 533 B ✓
Overall change 1.63 kB 1.63 kB ✓
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js tracing/mixed-modules Change
buildDuration 9.7s 9.8s ⚠️ +70ms
buildDurationCached 4.1s 4s -15ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +107 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js tracing/mixed-modules Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.357 2.292 -0.07
/ avg req/sec 1060.76 1090.61 +29.85
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.25 1.315 ⚠️ +0.06
/error-in-render avg req/sec 2000.6 1901.81 ⚠️ -98.79
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js tracing/mixed-modules Change
16.HASH.js gzip 186 B 186 B ✓
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB ✓
framework.HASH.js gzip 41.9 kB 41.9 kB ✓
main-HASH.js gzip 10.7 kB 10.7 kB ✓
webpack-HASH.js gzip 1.19 kB 1.19 kB ✓
Overall change 68.1 kB 68.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js tracing/mixed-modules Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js tracing/mixed-modules Change
_app-HASH.js gzip 964 B 964 B ✓
_error-HASH.js gzip 3.8 kB 3.8 kB ✓
amp-HASH.js gzip 552 B 552 B ✓
css-HASH.js gzip 333 B 333 B ✓
dynamic-HASH.js gzip 2.87 kB 2.87 kB ✓
head-HASH.js gzip 3.06 kB 3.06 kB ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 231 B 231 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 298 B 298 B ✓
script-HASH.js gzip 3.03 kB 3.03 kB ✓
withRouter-HASH.js gzip 295 B 295 B ✓
30809af5c834..565.css gzip 125 B 125 B ✓
Overall change 18.1 kB 18.1 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js tracing/mixed-modules Change
_buildManifest.js gzip 500 B 500 B ✓
Overall change 500 B 500 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js tracing/mixed-modules Change
index.html gzip 584 B 584 B ✓
link.html gzip 596 B 596 B ✓
withRouter.html gzip 577 B 577 B ✓
Overall change 1.76 kB 1.76 kB ✓
Commit: fa7c9f6

@ijjk ijjk merged commit 14a999e into vercel:canary Sep 3, 2021
@ijjk ijjk deleted the tracing/mixed-modules branch September 3, 2021 16:30
bordeo pushed a commit to filoblu/next.js that referenced this pull request Sep 6, 2021
Merge branch 'canary' of github.com:filoblu/next.js into canary
b907bbe 
* 'canary' of github.com:filoblu/next.js:
  Reuse warning from postcss-loader (vercel#28727)
  Add RenderResult class (vercel#28776)
  v11.1.3-canary.8
  feat: Adding generic typing for previewData (vercel#28668)
  Change create-next-app getting started text in TypeScript template (vercel#28718)
  [ESLint Plugin] Updates `no-document-import-in-page` rule to use `path` separators (vercel#28768)
  Update to new npm publish token (vercel#28772)
  Ensure build trace handles mixed modules (vercel#28770)
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @styfle