Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typo #28817

Merged
merged 4 commits into from Sep 6, 2021
Merged

doc: fix typo #28817

merged 4 commits into from Sep 6, 2021

Conversation

well-balanced
Copy link
Contributor

@well-balanced well-balanced commented Sep 6, 2021

  const stringValue =
    typeof value === 'object' ? 'j:' + JSON.stringify(value) : String(value)
  ...
  // String() is not necessary
  res.setHeader('Set-Cookie', serialize(name, String(stringValue), options))

stringValue has already been converted to string type from the earlier code line. therefore this code line is useless.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@timneutkens timneutkens merged commit 970f85e into vercel:canary Sep 6, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants