Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update next/link API docs to mention a11y and ESLint rule. #28841

Merged
merged 3 commits into from Sep 7, 2021

Conversation

leerob
Copy link
Member

@leerob leerob commented Sep 6, 2021

@ijjk
Copy link
Member

ijjk commented Sep 7, 2021

Failing test suites

Commit: 61b620e

test/acceptance/ReactRefreshLogBox.dev.test.js

  • logbox: can recover from a syntax error without losing state

Expand output

● logbox: can recover from a syntax error without losing state

expect(received).toBe(expected) // Object.is equality

Expected: "Count: 1"
Received: "1"

  46 |       import { useCallback, useState } from 'react'
  47 |
> 48 |       export default function Index() {
     |        ^
  49 |         const [count, setCount] = useState(0)
  50 |         const increment = useCallback(() => setCount(c => c + 1), [setCount])
  51 |         return (

  at Object.<anonymous> (acceptance/ReactRefreshLogBox.dev.test.js:48:8)

@kodiakhq kodiakhq bot merged commit 1fcd8c2 into canary Sep 7, 2021
@kodiakhq kodiakhq bot deleted the leerob-patch-1 branch September 7, 2021 15:10
bordeo pushed a commit to filoblu/next.js that referenced this pull request Sep 8, 2021
* canary:
  v11.1.3-canary.14
  Ensure timed out prefetches are cleaned up correctly (vercel#28899)
  Fix/swc minify (vercel#28898)
  Update concurrent tests and enable experimental streaming (vercel#28892)
  Fix Typo in "with-eslint" Example docs (vercel#28601)
  Examples Prepr CMS update (vercel#28871)
  fixes with-typescript-graphql: unable to resolve dependency tree (vercel#28637)
  Update `next/link` API docs to mention a11y and ESLint rule. (vercel#28841)
  Trim large test output to not exceed limit (vercel#28881)
  Updates @react-three/drei version and other dependencies. (vercel#28755)
  Remove unused dependencies (vercel#28876)
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants