Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(docs) Add permanent property in redirect object #28852

Merged
merged 1 commit into from Sep 6, 2021

Conversation

arvindell
Copy link
Contributor

I found that an example for a redirect rule in the documentation doesn't have the required property permanent. I noticed this because I tried to use that same rule but building fails with the following message:

`permanent` is not set to `true` or `false` for route {"source":"/:path((?!another-page$).*)","has":[{"type":"host","value":"example.com"}],"destination":"/another-page"}


Error: Invalid redirect found

My PR simply adds the missing permanent property as false to be consistent with the rest.

Documentation / Examples

  • Make sure the linting passes

@arvindell arvindell changed the title (docs) Add permanent property in redirect object (docs) Add permanent property in redirect object Sep 6, 2021
@kodiakhq kodiakhq bot merged commit 2425f47 into vercel:canary Sep 6, 2021
bordeo pushed a commit to filoblu/next.js that referenced this pull request Sep 7, 2021
* canary:
  Remove unused profiler (vercel#28844)
  Remove outdated webpack conformance experiment (vercel#28846)
  v11.1.3-canary.13
  v11.1.3-canary.12
  Upgrade upload-artifact action
  v11.1.3-canary.11
  v11.1.3-canary.10
  Update precompiled
  with-stitches example fixes vercel#28650 (vercel#28652)
  (docs) Add `permanent` property in redirect object (vercel#28852)
  (docs) Remove duplicate comma (vercel#28850)
  v11.1.3-canary.9
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants