Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMR for _app can fail to trigger when added after starting dev server #28888

Closed
ijjk opened this issue Sep 7, 2021 · 2 comments
Closed

HMR for _app can fail to trigger when added after starting dev server #28888

ijjk opened this issue Sep 7, 2021 · 2 comments
Assignees
Labels
Developer Experience Issues related to Next.js logs, Error overlay, etc. Webpack Related to Webpack with Next.js.

Comments

@ijjk
Copy link
Member

ijjk commented Sep 7, 2021

When adding an _app file after starting the dev server (next dev) HMR can fail to trigger in some cases like when an error is added in _app (a syntax error or missing import) and then the error is fixed.

We need to ensure the HMR behaves correctly regardless of if _app was present before or after starting the dev server.

This might be related to the new fallback handling we're leveraging in webpack 5 that was added in #28279

@ijjk ijjk added the kind: bug label Sep 7, 2021
@ijjk ijjk self-assigned this Sep 7, 2021
@timneutkens timneutkens added Webpack Related to Webpack with Next.js. Developer Experience Issues related to Next.js logs, Error overlay, etc. labels Nov 18, 2021
@ijjk
Copy link
Member Author

ijjk commented Feb 3, 2022

Closing as this should be resolved now and we have test cases covering _app errors and adding/removing

@ijjk ijjk closed this as completed Feb 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2022

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Developer Experience Issues related to Next.js logs, Error overlay, etc. Webpack Related to Webpack with Next.js.
Projects
None yet
Development

No branches or pull requests

2 participants