Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next/dynamic: Accept pagesDir #29055

Merged
merged 7 commits into from Sep 13, 2021
Merged

next/dynamic: Accept pagesDir #29055

merged 7 commits into from Sep 13, 2021

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Sep 13, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

This PR adds pagesDir to options and fixes deserialization issue.

@ijjk
Copy link
Member

ijjk commented Sep 13, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary kdy1/next.js pages-dir Change
buildDuration 12.2s 12.1s -114ms
buildDurationCached 3.1s 3.1s ⚠️ +17ms
nodeModulesSize 47 MB 47 MB
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js pages-dir Change
/ failed reqs 0 0
/ total time (seconds) 2.627 2.59 -0.04
/ avg req/sec 951.79 965.4 +13.61
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.292 1.274 -0.02
/error-in-render avg req/sec 1935.29 1963.08 +27.79
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js pages-dir Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 26.6 kB 26.6 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.4 kB 70.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js pages-dir Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js pages-dir Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js pages-dir Change
_buildManifest.js gzip 492 B 492 B
Overall change 492 B 492 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js pages-dir Change
index.html gzip 539 B 539 B
link.html gzip 552 B 552 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB

Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary kdy1/next.js pages-dir Change
buildDuration 9.9s 10.1s ⚠️ +118ms
buildDurationCached 4.4s 4.1s -270ms
nodeModulesSize 47 MB 47 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js pages-dir Change
/ failed reqs 0 0
/ total time (seconds) 2.652 2.648 0
/ avg req/sec 942.71 944.26 +1.55
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.282 1.285 0
/error-in-render avg req/sec 1949.45 1946.22 ⚠️ -3.23
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js pages-dir Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 13.8 kB 13.8 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js pages-dir Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js pages-dir Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.03 kB 3.03 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js pages-dir Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js pages-dir Change
index.html gzip 585 B 585 B
link.html gzip 597 B 597 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: ea229b0

@ijjk
Copy link
Member

ijjk commented Sep 13, 2021

Failing test suites

Commit: ea229b0

test/integration/config/test/index.test.js

  • Configuration > should log webpack version correctly
Expand output

● Configuration › should log webpack version correctly

expect(received).toContain(expected) // indexOf

Expected substring: "Using webpack 4. Reason: webpack5 flag is set to false in next.config.js"
Received string:    "Debugger listening on ws://127.0.0.1:9229/44060d32-32c9-4d99-af87-3210e56da639
For help, see: https://nodejs.org/en/docs/inspector
ready - started server on 0.0.0.0:35747, url: http://localhost:35747
info  - Using webpack 4 in Next.js is deprecated. Please upgrade to using webpack 5: https://nextjs.org/docs/messages/webpack5
Warning: Built-in CSS support is being disabled due to custom CSS configuration being detected.
See here for more info: https://nextjs.org/docs/messages/built-in-css-disabled·
event - compiled successfully
event - build page: /next-config
wait  - compiling...
event - build page: /build-id
event - build page: /webpack-css
event - build page: /next/dist/pages/_error
event - compiled successfully
"

  44 |   })
  45 |
> 46 |   afterAll(() => {
     |                   ^
  47 |     killApp(context.server)
  48 |   })
  49 |

  at Object.<anonymous> (integration/config/test/index.test.js:46:32)

@timneutkens timneutkens merged commit fd2af14 into vercel:canary Sep 13, 2021
@kdy1 kdy1 deleted the pages-dir branch September 13, 2021 11:37
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants