Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trace ignores for next import #29119

Merged
merged 1 commit into from Sep 15, 2021
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Sep 15, 2021

This ensures we don't accidentally trace all of next when import 'next' is found in a file which can occur from importing types from next.

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ijjk
Copy link
Member Author

ijjk commented Sep 15, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/trace-ignores Change
buildDuration 12.5s 12.4s -37ms
buildDurationCached 3.1s 3.2s ⚠️ +67ms
nodeModulesSize 182 MB 182 MB ⚠️ +97 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/trace-ignores Change
/ failed reqs 0 0
/ total time (seconds) 2.603 2.644 ⚠️ +0.04
/ avg req/sec 960.43 945.53 ⚠️ -14.9
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.318 1.331 ⚠️ +0.01
/error-in-render avg req/sec 1896.53 1878.19 ⚠️ -18.34
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/trace-ignores Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 26.6 kB 26.6 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.4 kB 70.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/trace-ignores Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/trace-ignores Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/trace-ignores Change
_buildManifest.js gzip 492 B 492 B
Overall change 492 B 492 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/trace-ignores Change
index.html gzip 541 B 541 B
link.html gzip 552 B 552 B
withRouter.html gzip 533 B 533 B
Overall change 1.63 kB 1.63 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/trace-ignores Change
buildDuration 6.3s 6.3s ⚠️ +1ms
buildDurationCached 3.1s 3s -97ms
nodeModulesSize 182 MB 182 MB ⚠️ +97 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/trace-ignores Change
/ failed reqs 0 0
/ total time (seconds) 2.655 2.656 0
/ avg req/sec 941.67 941.24 ⚠️ -0.43
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.309 1.322 ⚠️ +0.01
/error-in-render avg req/sec 1909.51 1891.05 ⚠️ -18.46
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/trace-ignores Change
264.HASH.js gzip 179 B 179 B
675-HASH.js gzip 13.8 kB 13.8 kB
framework-HASH.js gzip 50.7 kB 50.7 kB
main-HASH.js gzip 34.4 kB 34.4 kB
webpack-HASH.js gzip 1.65 kB 1.65 kB
Overall change 101 kB 101 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/trace-ignores Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/trace-ignores Change
_app-HASH.js gzip 1.33 kB 1.33 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 331 B 331 B
css-HASH.js gzip 352 B 352 B
dynamic-HASH.js gzip 2.8 kB 2.8 kB
head-HASH.js gzip 356 B 356 B
hooks-HASH.js gzip 652 B 652 B
image-HASH.js gzip 575 B 575 B
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.2 kB 2.2 kB
routerDirect..HASH.js gzip 327 B 327 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 323 B 323 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.2 kB 10.2 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/trace-ignores Change
_buildManifest.js gzip 515 B 515 B
Overall change 515 B 515 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/trace-ignores Change
index.html gzip 539 B 539 B
link.html gzip 551 B 551 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB
Commit: 4ca0889

@ijjk
Copy link
Member Author

ijjk commented Sep 15, 2021

Failing test suites

Commit: 4ca0889

test/integration/app-document-remove-hmr/test/index.test.js

  • _app removal HMR > should HMR when _document is removed
Expand output

● _app removal HMR › should HMR when _document is removed

TIMED OUT: success

<head><meta charset="utf-8"><meta name="viewport" content="width=device-width"><meta name="next-head-count" content="2"><noscript data-n-css=""></noscript><script defer="" nomodule="" src="/_next/static/chunks/polyfills.js?ts=1631734498401"></script><script src="/_next/static/chunks/webpack.js?ts=1631734498401" defer=""></script><script src="/_next/static/chunks/main.js?ts=1631734498401" defer=""></script><script src="/_next/static/chunks/pages/_app.js?ts=1631734498401" defer=""></script><script src="/_next/static/chunks/pages/index.js?ts=1631734498401" defer=""></script><script src="/_next/static/development/_buildManifest.js?ts=1631734498401" defer=""></script><script src="/_next/static/development/_ssgManifest.js?ts=1631734498401" defer=""></script><noscript id="__next_css__DO_NOT_USE__"></noscript></head><body><p>custom _document</p><div id="__next"><p>custom _app</p><p>index page</p></div><script src="/_next/static/chunks/react-refresh.js?ts=1631734498401"></script><script id="__NEXT_DATA__" type="application/json">{"props":{"pageProps":{}},"page":"/","query":{},"buildId":"development","nextExport":true,"autoExport":true,"isFallback":false,"scriptLoader":[]}</script><div id="__next-build-watcher" style="position: fixed; bottom: 10px; right: 20px; width: 0px; height: 0px; z-index: 99999;"></div><next-route-announcer><p aria-live="assertive" id="__next-route-announcer__" role="alert" style="border: 0px; clip: rect(0px, 0px, 0px, 0px); height: 1px; margin: -1px; overflow: hidden; padding: 0px; position: absolute; width: 1px; white-space: nowrap; overflow-wrap: normal;"></p></next-route-announcer></body>

  440 |
  441 |   if (hardError) {
> 442 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  443 |   }
  444 |   return false
  445 | }

  at Object.check (lib/next-test-utils.js:442:11)
  at Object.<anonymous> (integration/app-document-remove-hmr/test/index.test.js:123:7)

@ijjk ijjk merged commit e313398 into vercel:canary Sep 15, 2021
@ijjk ijjk deleted the update/trace-ignores branch September 15, 2021 20:00
bordeo pushed a commit to filoblu/next.js that referenced this pull request Sep 16, 2021
* canary: (41 commits)
  Add client-side debugging instructions (vercel#28815)
  v11.1.3-canary.19
  Update next-swc binaries (vercel#29132)
  Fix partial one off global selectors (vercel#29128)
  Update trace ignores for next import (vercel#29119)
  Development tracing improvements (vercel#29076)
  Remove log from failing to parse source map (vercel#29118)
  Remove inert font tag in font optimization (vercel#28869)
  v11.1.3-canary.18
  Update Redux example to use Toolkit + update dependencies. (vercel#29104)
  Ensure browser instances are not re-created un-necessarily (vercel#29091)
  Update styled-jsx (vercel#29103)
  v11.1.3-canary.17
  Add/styled jsx swc (vercel#29005)
  v11.1.3-canary.16
  Fix host segment replacing for custom routes (vercel#29090)
  Add stats config for SWC (vercel#28883)
  reload the page to show 404 when receiving `invalid` event from on-demand-entries (vercel#29074)
  Add crossOrigin type to the NextConfig (vercel#29033)
  Fix/upload binary artifact (vercel#29069)
  ...
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants