Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next/images dont support lazy load w/ preact #29120

Closed
knenkne opened this issue Sep 15, 2021 · 5 comments
Closed

Next/images dont support lazy load w/ preact #29120

knenkne opened this issue Sep 15, 2021 · 5 comments
Labels
bug Issue was opened via the bug report template. please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity

Comments

@knenkne
Copy link

knenkne commented Sep 15, 2021

What version of Next.js are you using?

11.1.0

What version of Node.js are you using?

16.4.0

What browser are you using?

Chrome

What operating system are you using?

macOS, Windows

How are you deploying your application?

next start, Vercel

Describe the Bug

I've switched to preact recently, but eventually faced the issue that image's lazy loading stop working and it has eager behaviour

React deployment with only 10 images in the viewport: https://sberify-hq04ut6xk-knenkne.vercel.app/
image

Preact deployment with 50 more images out of the viewport: https://sberify-rfxxh7ed6-knenkne.vercel.app/
image

Expected Behavior

Next/image works correctly with preact

To Reproduce

Alias react as preact in your next.config.js
image

@knenkne
Copy link
Author

knenkne commented Sep 15, 2021

Alright this is duplicate of #26621 (comment)

@knenkne knenkne closed this as completed Sep 15, 2021
@knenkne
Copy link
Author

knenkne commented Sep 15, 2021

Ok, I've figured out that it was fixed at 11.1.1 somehow, and now I've another scenario:
Initial load at Chrome (works as expected):
image
After page refresh (all images were loaded):
image
In FF all the images were loaded even at initial load, u can test it here https://sberify-eesq09sc7-knenkne.vercel.app/
It also seems like the error occurs with not static images

@knenkne knenkne reopened this Sep 15, 2021
@jankaifer jankaifer added the please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity label Nov 30, 2022
@github-actions
Copy link
Contributor

We cannot recreate the issue with the provided information. Please add a reproduction in order for us to be able to investigate.

Why was this issue marked with the please add a complete reproduction label?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We prefer a link to a public GitHub repository (template), but you can also use a tool like CodeSandbox or StackBlitz.

To make sure the issue is resolved as quickly as possible, please make sure that the reproduction is as minimal as possible. This means that you should remove unnecessary code, files, and dependencies that do not contribute to the issue.

Please test your reproduction against the latest version of Next.js (next@canary) to make sure your issue has not already been fixed.

I added a link, why was it still marked?

Ensure the link is pointing to a codebase that is accessible (e.g. not a private repository). "example.com", "n/a", "will add later", etc. are not acceptable links -- we need to see a public codebase. See the above section for accepted links.

What happens if I don't provide a sufficient minimal reproduction?

Issues with the please add a complete reproduction label that receives no meaningful activity (e.g. new comments with a reproduction link) are automatically closed and locked after 30 days.

If your issue has not been resolved in that time and it has been closed/locked, please open a new issue with the required reproduction.

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps. Furthermore, you can upvote the issue using the 👍 reaction on the topmost comment (please do not comment "I have the same issue" without repro steps). Then, we can sort issues by votes to prioritize.

I think my reproduction is good enough, why aren't you looking into it quicker?

We look into every Next.js issue and constantly monitor open issues for new comments.

However, sometimes we might miss one or two due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources

@balazsorban44
Copy link
Member

This issue has been automatically closed because it wasn't verified against next@canary. If you think it was closed by accident, please leave a comment. If you are running into a similar issue, please open a new issue with a reproduction. Thank you.

@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template. please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity
Projects
None yet
Development

No branches or pull requests

3 participants