New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix partial one off global selectors #29128
Fix partial one off global selectors #29128
Conversation
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | padmaia/next.js fix/styled-jsx-global-selectors | Change | |
---|---|---|---|
buildDuration | 13.5s | 13.6s | |
buildDurationCached | 3.4s | 3.2s | -235ms |
nodeModulesSize | 182 MB | 182 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | padmaia/next.js fix/styled-jsx-global-selectors | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.894 | 2.939 | |
/ avg req/sec | 863.99 | 850.64 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.429 | 1.378 | -0.05 |
/error-in-render avg req/sec | 1749.28 | 1814.66 | +65.38 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | padmaia/next.js fix/styled-jsx-global-selectors | Change | |
---|---|---|---|
745.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 26.6 kB | 26.6 kB | ✓ |
webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
Overall change | 70.4 kB | 70.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | padmaia/next.js fix/styled-jsx-global-selectors | Change | |
---|---|---|---|
polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | padmaia/next.js fix/styled-jsx-global-selectors | Change | |
---|---|---|---|
_app-HASH.js gzip | 979 B | 979 B | ✓ |
_error-HASH.js gzip | 194 B | 194 B | ✓ |
amp-HASH.js gzip | 312 B | 312 B | ✓ |
css-HASH.js gzip | 329 B | 329 B | ✓ |
dynamic-HASH.js gzip | 2.67 kB | 2.67 kB | ✓ |
head-HASH.js gzip | 351 B | 351 B | ✓ |
hooks-HASH.js gzip | 918 B | 918 B | ✓ |
image-HASH.js gzip | 4.14 kB | 4.14 kB | ✓ |
index-HASH.js gzip | 261 B | 261 B | ✓ |
link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
routerDirect..HASH.js gzip | 318 B | 318 B | ✓ |
script-HASH.js gzip | 387 B | 387 B | ✓ |
withRouter-HASH.js gzip | 320 B | 320 B | ✓ |
bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
Overall change | 13 kB | 13 kB | ✓ |
Client Build Manifests
vercel/next.js canary | padmaia/next.js fix/styled-jsx-global-selectors | Change | |
---|---|---|---|
_buildManifest.js gzip | 492 B | 492 B | ✓ |
Overall change | 492 B | 492 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | padmaia/next.js fix/styled-jsx-global-selectors | Change | |
---|---|---|---|
index.html gzip | 541 B | 541 B | ✓ |
link.html gzip | 552 B | 552 B | ✓ |
withRouter.html gzip | 533 B | 533 B | ✓ |
Overall change | 1.63 kB | 1.63 kB | ✓ |
Default Build with SWC (Increase detected ⚠️ )
General Overall increase ⚠️
vercel/next.js canary | padmaia/next.js fix/styled-jsx-global-selectors | Change | |
---|---|---|---|
buildDuration | 6.7s | 6.8s | |
buildDurationCached | 3.3s | 3.2s | -137ms |
nodeModulesSize | 182 MB | 182 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | padmaia/next.js fix/styled-jsx-global-selectors | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.942 | 2.783 | -0.16 |
/ avg req/sec | 849.73 | 898.41 | +48.68 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.419 | 1.332 | -0.09 |
/error-in-render avg req/sec | 1761.19 | 1876.51 | +115.32 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | padmaia/next.js fix/styled-jsx-global-selectors | Change | |
---|---|---|---|
264.HASH.js gzip | 179 B | 179 B | ✓ |
675-HASH.js gzip | 13.8 kB | 13.8 kB | ✓ |
framework-HASH.js gzip | 50.7 kB | 50.7 kB | ✓ |
main-HASH.js gzip | 34.4 kB | 34.4 kB | ✓ |
webpack-HASH.js gzip | 1.65 kB | 1.65 kB | ✓ |
Overall change | 101 kB | 101 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | padmaia/next.js fix/styled-jsx-global-selectors | Change | |
---|---|---|---|
polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | padmaia/next.js fix/styled-jsx-global-selectors | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error-HASH.js gzip | 179 B | 179 B | ✓ |
amp-HASH.js gzip | 331 B | 331 B | ✓ |
css-HASH.js gzip | 352 B | 352 B | ✓ |
dynamic-HASH.js gzip | 2.8 kB | 2.8 kB | ✓ |
head-HASH.js gzip | 356 B | 356 B | ✓ |
hooks-HASH.js gzip | 652 B | 652 B | ✓ |
image-HASH.js gzip | 575 B | 575 B | ✓ |
index-HASH.js gzip | 261 B | 261 B | ✓ |
link-HASH.js gzip | 2.2 kB | 2.2 kB | ✓ |
routerDirect..HASH.js gzip | 327 B | 327 B | ✓ |
script-HASH.js gzip | 392 B | 392 B | ✓ |
withRouter-HASH.js gzip | 323 B | 323 B | ✓ |
bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
Overall change | 10.2 kB | 10.2 kB | ✓ |
Client Build Manifests
vercel/next.js canary | padmaia/next.js fix/styled-jsx-global-selectors | Change | |
---|---|---|---|
_buildManifest.js gzip | 515 B | 515 B | ✓ |
Overall change | 515 B | 515 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | padmaia/next.js fix/styled-jsx-global-selectors | Change | |
---|---|---|---|
index.html gzip | 539 B | 539 B | ✓ |
link.html gzip | 551 B | 551 B | ✓ |
withRouter.html gzip | 532 B | 532 B | ✓ |
Overall change | 1.62 kB | 1.62 kB | ✓ |
Failing test suitesCommit: 3ccc651 test/development/acceptance/ReactRefreshLogBoxMisc.test.ts
Expand output● ReactRefreshLogBox › component props errors
● ReactRefreshLogBox › server-side only compilation errors
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I can add a parser api which can be used to parse > *
.
) | ||
.emit() | ||
}); | ||
new_selectors.push(selector.clone()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this clone()
required?
front_tokens.extend(args.tokens); | ||
front_tokens.extend(block_tokens); | ||
args.tokens = front_tokens; | ||
let complex_selectors = panic::catch_unwind(|| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will print something to console and it can be replaced with a match statement.
* canary: (41 commits) Add client-side debugging instructions (vercel#28815) v11.1.3-canary.19 Update next-swc binaries (vercel#29132) Fix partial one off global selectors (vercel#29128) Update trace ignores for next import (vercel#29119) Development tracing improvements (vercel#29076) Remove log from failing to parse source map (vercel#29118) Remove inert font tag in font optimization (vercel#28869) v11.1.3-canary.18 Update Redux example to use Toolkit + update dependencies. (vercel#29104) Ensure browser instances are not re-created un-necessarily (vercel#29091) Update styled-jsx (vercel#29103) v11.1.3-canary.17 Add/styled jsx swc (vercel#29005) v11.1.3-canary.16 Fix host segment replacing for custom routes (vercel#29090) Add stats config for SWC (vercel#28883) reload the page to show 404 when receiving `invalid` event from on-demand-entries (vercel#29074) Add crossOrigin type to the NextConfig (vercel#29033) Fix/upload binary artifact (vercel#29069) ...
A fix for some one off global selectors.
Example:
Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples