suggest incremental typescript for typescript >= 4.4.2 #29169

sokra · 2021-09-17T06:42:14Z

This is now safe to enable since it no longer causes performance regressions

ijjk · 2021-09-17T08:00:28Z

Failing test suites

Commit: 1ae9c69

test/integration/app-document-remove-hmr/test/index.test.js

_app removal HMR > should HMR when _document is removed

Expand output

● _app removal HMR › should HMR when _document is removed

TIMED OUT: success

<head><meta charset="utf-8"><meta name="viewport" content="width=device-width"><meta name="next-head-count" content="2"><noscript data-n-css=""></noscript><script defer="" nomodule="" src="/_next/static/chunks/polyfills.js?ts=1631865591816"></script><script src="/_next/static/chunks/webpack.js?ts=1631865591816" defer=""></script><script src="/_next/static/chunks/main.js?ts=1631865591816" defer=""></script><script src="/_next/static/chunks/pages/_app.js?ts=1631865591816" defer=""></script><script src="/_next/static/chunks/pages/index.js?ts=1631865591816" defer=""></script><script src="/_next/static/development/_buildManifest.js?ts=1631865591816" defer=""></script><script src="/_next/static/development/_ssgManifest.js?ts=1631865591816" defer=""></script><noscript id="__next_css__DO_NOT_USE__"></noscript></head><body><p>custom _document</p><div id="__next"><p>custom _app</p><p>index page</p></div><script src="/_next/static/chunks/react-refresh.js?ts=1631865591816"></script><script id="__NEXT_DATA__" type="application/json">{"props":{"pageProps":{}},"page":"/","query":{},"buildId":"development","nextExport":true,"autoExport":true,"isFallback":false,"scriptLoader":[]}</script><div id="__next-build-watcher" style="position: fixed; bottom: 10px; right: 20px; width: 0px; height: 0px; z-index: 99999;"></div><next-route-announcer><p aria-live="assertive" id="__next-route-announcer__" role="alert" style="border: 0px; clip: rect(0px, 0px, 0px, 0px); height: 1px; margin: -1px; overflow: hidden; padding: 0px; position: absolute; width: 1px; white-space: nowrap; overflow-wrap: normal;"></p></next-route-announcer></body>

  440 |
  441 |   if (hardError) {
> 442 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  443 |   }
  444 |   return false
  445 | }

  at Object.check (lib/next-test-utils.js:442:11)
  at Object.<anonymous> (integration/app-document-remove-hmr/test/index.test.js:123:7)

ijjk · 2021-09-17T15:16:27Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js feature/incremental-typechecking	Change
buildDuration	16s	15.9s	-72ms
buildDurationCached	3.9s	3.7s	-164ms
nodeModulesSize	182 MB	182 MB	⚠️ +439 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	vercel/next.js feature/incremental-typechecking	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.393	3.435	⚠️ +0.04
/ avg req/sec	736.74	727.73	⚠️ -9.01
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.873	1.919	⚠️ +0.05
/error-in-render avg req/sec	1334.69	1302.96	⚠️ -31.73

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js feature/incremental-typechecking	Change
745.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	26.7 kB	26.7 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	70.6 kB	70.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js feature/incremental-typechecking	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js feature/incremental-typechecking	Change
_app-HASH.js gzip	979 B	979 B	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	329 B	329 B	✓
dynamic-HASH.js gzip	2.67 kB	2.67 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	918 B	918 B	✓
image-HASH.js gzip	4.14 kB	4.14 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	318 B	318 B	✓
script-HASH.js gzip	387 B	387 B	✓
withRouter-HASH.js gzip	320 B	320 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	13 kB	13 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js feature/incremental-typechecking	Change
_buildManifest.js gzip	492 B	492 B	✓
Overall change	492 B	492 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js feature/incremental-typechecking	Change
index.html gzip	540 B	540 B	✓
link.html gzip	552 B	552 B	✓
withRouter.html gzip	534 B	534 B	✓
Overall change	1.63 kB	1.63 kB	✓

Default Build with SWC (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js feature/incremental-typechecking	Change
buildDuration	8.2s	7.9s	-341ms
buildDurationCached	3.8s	3.6s	-128ms
nodeModulesSize	182 MB	182 MB	⚠️ +439 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	vercel/next.js feature/incremental-typechecking	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.473	3.36	-0.11
/ avg req/sec	719.92	744.08	+24.16
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.919	1.924	0
/error-in-render avg req/sec	1302.44	1299.17	⚠️ -3.27

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js feature/incremental-typechecking	Change
264.HASH.js gzip	179 B	179 B	✓
675-HASH.js gzip	13.8 kB	13.8 kB	✓
framework-HASH.js gzip	50.7 kB	50.7 kB	✓
main-HASH.js gzip	34.6 kB	34.6 kB	✓
webpack-HASH.js gzip	1.65 kB	1.65 kB	✓
Overall change	101 kB	101 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js feature/incremental-typechecking	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js feature/incremental-typechecking	Change
_app-HASH.js gzip	1.32 kB	1.32 kB	✓
_error-HASH.js gzip	179 B	179 B	✓
amp-HASH.js gzip	315 B	315 B	✓
css-HASH.js gzip	330 B	330 B	✓
dynamic-HASH.js gzip	2.8 kB	2.8 kB	✓
head-HASH.js gzip	356 B	356 B	✓
hooks-HASH.js gzip	638 B	638 B	✓
image-HASH.js gzip	575 B	575 B	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	2.2 kB	2.2 kB	✓
routerDirect..HASH.js gzip	327 B	327 B	✓
script-HASH.js gzip	392 B	392 B	✓
withRouter-HASH.js gzip	323 B	323 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	10.1 kB	10.1 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js feature/incremental-typechecking	Change
_buildManifest.js gzip	512 B	512 B	✓
Overall change	512 B	512 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js feature/incremental-typechecking	Change
index.html gzip	538 B	538 B	✓
link.html gzip	550 B	550 B	✓
withRouter.html gzip	533 B	533 B	✓
Overall change	1.62 kB	1.62 kB	✓

Commit: 6a7106b

…config (#4248) Recently[1], nextjs started auto-defaulting the `incremental` tsconfig option[2] (which caches certain information build to build) to `true` in nextjs projects using typescript, by modifying the projects' `tsconfig` files. This incorporates that `tsconfig` change into the app we use for integration tests. [1] vercel/next.js#29169 [2] https://www.typescriptlang.org/tsconfig#incremental

suggest incremental typescript for typescript >= 4.4.2

c75e4af

sokra requested review from huozhi, ijjk, padmaia, shuding, styfle and timneutkens as code owners September 17, 2021 06:42

ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Sep 17, 2021

This comment has been minimized.

Sign in to view

timneutkens approved these changes Sep 17, 2021

View reviewed changes

Merge branch 'canary' into feature/incremental-typechecking

1ae9c69

This comment has been minimized.

Sign in to view

styfle approved these changes Sep 17, 2021

View reviewed changes

ijjk approved these changes Sep 17, 2021

View reviewed changes

Merge branch 'canary' into feature/incremental-typechecking

6a7106b

kodiakhq bot merged commit fa9ee19 into canary Sep 17, 2021

kodiakhq bot deleted the feature/incremental-typechecking branch September 17, 2021 15:42

kirjai mentioned this pull request Nov 8, 2021

chore(nxdev): set incremental to true nrwl/nx#7660

Merged

lobsterkatie mentioned this pull request Dec 7, 2021

chore(nextjs): Add incremental option to nextjs integration test tsconfig getsentry/sentry-javascript#4248

Merged

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

suggest incremental typescript for typescript >= 4.4.2 #29169

suggest incremental typescript for typescript >= 4.4.2 #29169

sokra commented Sep 17, 2021

This comment has been minimized.

ijjk commented Sep 17, 2021

This comment has been minimized.

ijjk commented Sep 17, 2021

suggest incremental typescript for typescript >= 4.4.2 #29169

suggest incremental typescript for typescript >= 4.4.2 #29169

Conversation

sokra commented Sep 17, 2021

This comment has been minimized.

ijjk commented Sep 17, 2021

Failing test suites

This comment has been minimized.

ijjk commented Sep 17, 2021

Stats from current PR