Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compilation relationship #29174

Merged
merged 7 commits into from Sep 20, 2021
Merged

fix compilation relationship #29174

merged 7 commits into from Sep 20, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Sep 17, 2021

Fixes the relationship between trace spans between compilations in development.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Sep 20, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js bugfix/span-relationship Change
buildDuration 14.3s 14s -206ms
buildDurationCached 3.6s 3.5s -64ms
nodeModulesSize 182 MB 182 MB ⚠️ +2.67 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js bugfix/span-relationship Change
/ failed reqs 0 0
/ total time (seconds) 2.993 3.102 ⚠️ +0.11
/ avg req/sec 835.17 806.01 ⚠️ -29.16
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.531 1.584 ⚠️ +0.05
/error-in-render avg req/sec 1632.91 1578.38 ⚠️ -54.53
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bugfix/span-relationship Change
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 26.7 kB 26.7 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.6 kB 70.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/span-relationship Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js bugfix/span-relationship Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/span-relationship Change
_buildManifest.js gzip 493 B 493 B
Overall change 493 B 493 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bugfix/span-relationship Change
index.html gzip 540 B 540 B
link.html gzip 552 B 552 B
withRouter.html gzip 534 B 534 B
Overall change 1.63 kB 1.63 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js bugfix/span-relationship Change
buildDuration 7.1s 7.1s ⚠️ +18ms
buildDurationCached 3.5s 3.5s ⚠️ +38ms
nodeModulesSize 182 MB 182 MB ⚠️ +2.67 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js bugfix/span-relationship Change
/ failed reqs 0 0
/ total time (seconds) 3.104 3.138 ⚠️ +0.03
/ avg req/sec 805.5 796.63 ⚠️ -8.87
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.539 1.6 ⚠️ +0.06
/error-in-render avg req/sec 1624.28 1562.84 ⚠️ -61.44
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bugfix/span-relationship Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.7 kB 50.7 kB
main-HASH.js gzip 34.6 kB 34.6 kB
webpack-HASH.js gzip 1.65 kB 1.65 kB
Overall change 101 kB 101 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/span-relationship Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js bugfix/span-relationship Change
_app-HASH.js gzip 1.32 kB 1.32 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.8 kB 2.8 kB
head-HASH.js gzip 356 B 356 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 573 B 573 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 2.2 kB 2.2 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/span-relationship Change
_buildManifest.js gzip 511 B 511 B
Overall change 511 B 511 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bugfix/span-relationship Change
index.html gzip 539 B 539 B
link.html gzip 551 B 551 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB
Commit: 907abc3

@ijjk
Copy link
Member

ijjk commented Sep 20, 2021

Failing test suites

Commit: 907abc3

test/development/acceptance/ReactRefreshLogBoxMisc.test.ts

  • ReactRefreshLogBox > server-side only compilation errors
Expand output

● ReactRefreshLogBox › server-side only compilation errors

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  171 |               passHref={undefined}
  172 |               prefetch={undefined}
> 173 |             >
      |              ^
  174 |               Abc
  175 |             </Link>
  176 |           )

  at Object.<anonymous> (development/acceptance/ReactRefreshLogBoxMisc.test.ts:173:47)

@timneutkens timneutkens merged commit e90825a into canary Sep 20, 2021
@timneutkens timneutkens deleted the bugfix/span-relationship branch September 20, 2021 20:19
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants