Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker usage for running development tests #29264

Merged
merged 4 commits into from Sep 21, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Sep 21, 2021

This attempts to fix the playwright docker tests failing recently potentially from a bad image publish by removing docker usage for running these tests. This disables a test that was failing from invalid snapshots in GitHub actions in the meantime to allow us to not need to run in docker.

x-ref: https://github.com/vercel/next.js/runs/3664463806

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Sep 21, 2021
@ijjk

This comment has been minimized.

@ijjk ijjk changed the title Lock docker image tag to version Remove docker usage for running development tests Sep 21, 2021
@ijjk ijjk marked this pull request as ready for review September 21, 2021 16:13
timneutkens
timneutkens previously approved these changes Sep 21, 2021
@ijjk
Copy link
Member Author

ijjk commented Sep 21, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js update/docker-image-tag Change
buildDuration 14.9s 14.7s -194ms
buildDurationCached 3.7s 3.6s -163ms
nodeModulesSize 182 MB 182 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/docker-image-tag Change
/ failed reqs 0 0
/ total time (seconds) 3.114 3.091 -0.02
/ avg req/sec 802.86 808.79 +5.93
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.583 1.628 ⚠️ +0.04
/error-in-render avg req/sec 1579.17 1535.96 ⚠️ -43.21
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/docker-image-tag Change
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 26.8 kB 26.8 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.6 kB 70.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/docker-image-tag Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/docker-image-tag Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/docker-image-tag Change
_buildManifest.js gzip 493 B 493 B
Overall change 493 B 493 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/docker-image-tag Change
index.html gzip 539 B 539 B
link.html gzip 550 B 550 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js update/docker-image-tag Change
buildDuration 7.6s 7.5s -98ms
buildDurationCached 3.6s 3.6s -21ms
nodeModulesSize 182 MB 182 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/docker-image-tag Change
/ failed reqs 0 0
/ total time (seconds) 3.072 3.104 ⚠️ +0.03
/ avg req/sec 813.7 805.41 ⚠️ -8.29
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.563 1.59 ⚠️ +0.03
/error-in-render avg req/sec 1599.5 1572.4 ⚠️ -27.1
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/docker-image-tag Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.7 kB 50.7 kB
main-HASH.js gzip 34.7 kB 34.7 kB
webpack-HASH.js gzip 1.65 kB 1.65 kB
Overall change 101 kB 101 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/docker-image-tag Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/docker-image-tag Change
_app-HASH.js gzip 1.32 kB 1.32 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.8 kB 2.8 kB
head-HASH.js gzip 356 B 356 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 573 B 573 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 2.2 kB 2.2 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/docker-image-tag Change
_buildManifest.js gzip 511 B 511 B
Overall change 511 B 511 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/docker-image-tag Change
index.html gzip 538 B 538 B
link.html gzip 550 B 550 B
withRouter.html gzip 531 B 531 B
Overall change 1.62 kB 1.62 kB
Commit: 0d3e7c4

@sokra sokra merged commit 800b2be into vercel:canary Sep 21, 2021
@ijjk ijjk deleted the update/docker-image-tag branch September 21, 2021 17:06
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants