Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure initial imports are included in traces correctly #29437

Merged
merged 4 commits into from Sep 28, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Sep 27, 2021

This ensures we include dependencies in the traces correctly as we ignore initial trace items since we already are aware of them. This removes dependency items from the initial trace list since they are traced correctly without being included there.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Sep 27, 2021
@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review September 27, 2021 18:56
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Sep 28, 2021

Failing test suites

Commit: 7adee06

test/development/basic-basepath/hmr.test.ts

  • basic HMR > Error Recovery > should show the error on all pages
  • basic HMR > Error Recovery > should recover from errors in the render function
  • basic HMR > Error Recovery > should recover after undefined exported as default
Expand output

● basic HMR › Error Recovery › should show the error on all pages

TIMED OUT: /This is the contact page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic-basepath/hmr.test.ts:389:9)

● basic HMR › Error Recovery › should recover from errors in the render function

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic-basepath/hmr.test.ts:458:9)

● basic HMR › Error Recovery › should recover after undefined exported as default

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `basic HMR Error Recovery should recover after undefined exported as default 1`

- Snapshot  - 3
+ Received  + 1

   1 of 1 unhandled error
- Server Error
+ Unhandled Runtime Error

  Error: The default export is not a React Component in page: "/hmr/about7"
-
- This error happened while generating the page. Any console logs will be displayed in the terminal window.

  603 |         await next.patchFile(aboutPage, aboutContent)
  604 |
> 605 |         if (browser) {
      |                       ^
  606 |           await check(
  607 |             () => getBrowserBodyText(browser),
  608 |             /This is the about page/

  at Object.<anonymous> (development/basic-basepath/hmr.test.ts:605:23)

@ijjk
Copy link
Member Author

ijjk commented Sep 28, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/initial-trace-items Change
buildDuration 15.8s 15.7s -80ms
buildDurationCached 3.9s 4s ⚠️ +108ms
nodeModulesSize 181 MB 181 MB -66 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/initial-trace-items Change
/ failed reqs 0 0
/ total time (seconds) 3.659 3.505 -0.15
/ avg req/sec 683.16 713.17 +30.01
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.216 2.023 -0.19
/error-in-render avg req/sec 1128.12 1236.06 +107.94
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/initial-trace-items Change
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27 kB 27 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.8 kB 70.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/initial-trace-items Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/initial-trace-items Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.15 kB 4.15 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/initial-trace-items Change
_buildManifest.js gzip 494 B 494 B
Overall change 494 B 494 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/initial-trace-items Change
index.html gzip 540 B 540 B
link.html gzip 551 B 551 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/initial-trace-items Change
buildDuration 8s 8s -71ms
buildDurationCached 3.9s 3.9s ⚠️ +57ms
nodeModulesSize 181 MB 181 MB -66 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/initial-trace-items Change
/ failed reqs 0 0
/ total time (seconds) 3.534 3.45 -0.08
/ avg req/sec 707.37 724.56 +17.19
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.011 2.043 ⚠️ +0.03
/error-in-render avg req/sec 1242.85 1223.58 ⚠️ -19.27
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/initial-trace-items Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.7 kB 50.7 kB
main-HASH.js gzip 34.9 kB 34.9 kB
webpack-HASH.js gzip 1.64 kB 1.64 kB
Overall change 101 kB 101 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/initial-trace-items Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/initial-trace-items Change
_app-HASH.js gzip 1.33 kB 1.33 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.79 kB 2.79 kB
head-HASH.js gzip 356 B 356 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 573 B 573 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 2.2 kB 2.2 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/initial-trace-items Change
_buildManifest.js gzip 512 B 512 B
Overall change 512 B 512 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/initial-trace-items Change
index.html gzip 537 B 537 B
link.html gzip 548 B 548 B
withRouter.html gzip 529 B 529 B
Overall change 1.61 kB 1.61 kB
Commit: 7adee06

@ijjk ijjk closed this Sep 28, 2021
@ijjk ijjk reopened this Sep 28, 2021
@ijjk ijjk merged commit a71addf into vercel:canary Sep 28, 2021
@ijjk ijjk deleted the fix/initial-trace-items branch September 28, 2021 17:04
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants