New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure initial imports are included in traces correctly #29437
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ijjk
requested review from
huozhi,
padmaia,
shuding,
styfle and
timneutkens
as code owners
September 27, 2021 18:56
styfle
approved these changes
Sep 28, 2021
This comment has been minimized.
This comment has been minimized.
Failing test suitesCommit: 7adee06 test/development/basic-basepath/hmr.test.ts
Expand output● basic HMR › Error Recovery › should show the error on all pages
● basic HMR › Error Recovery › should recover from errors in the render function
● basic HMR › Error Recovery › should recover after undefined exported as default
|
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | ijjk/next.js fix/initial-trace-items | Change | |
---|---|---|---|
buildDuration | 15.8s | 15.7s | -80ms |
buildDurationCached | 3.9s | 4s | |
nodeModulesSize | 181 MB | 181 MB | -66 B |
Page Load Tests Overall increase ✓
vercel/next.js canary | ijjk/next.js fix/initial-trace-items | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 3.659 | 3.505 | -0.15 |
/ avg req/sec | 683.16 | 713.17 | +30.01 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 2.216 | 2.023 | -0.19 |
/error-in-render avg req/sec | 1128.12 | 1236.06 | +107.94 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | ijjk/next.js fix/initial-trace-items | Change | |
---|---|---|---|
779.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 27 kB | 27 kB | ✓ |
webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
Overall change | 70.8 kB | 70.8 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | ijjk/next.js fix/initial-trace-items | Change | |
---|---|---|---|
polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | ijjk/next.js fix/initial-trace-items | Change | |
---|---|---|---|
_app-HASH.js gzip | 977 B | 977 B | ✓ |
_error-HASH.js gzip | 194 B | 194 B | ✓ |
amp-HASH.js gzip | 311 B | 311 B | ✓ |
css-HASH.js gzip | 328 B | 328 B | ✓ |
dynamic-HASH.js gzip | 2.67 kB | 2.67 kB | ✓ |
head-HASH.js gzip | 351 B | 351 B | ✓ |
hooks-HASH.js gzip | 918 B | 918 B | ✓ |
image-HASH.js gzip | 4.15 kB | 4.15 kB | ✓ |
index-HASH.js gzip | 260 B | 260 B | ✓ |
link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
routerDirect..HASH.js gzip | 320 B | 320 B | ✓ |
script-HASH.js gzip | 386 B | 386 B | ✓ |
withRouter-HASH.js gzip | 319 B | 319 B | ✓ |
bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
Overall change | 13 kB | 13 kB | ✓ |
Client Build Manifests
vercel/next.js canary | ijjk/next.js fix/initial-trace-items | Change | |
---|---|---|---|
_buildManifest.js gzip | 494 B | 494 B | ✓ |
Overall change | 494 B | 494 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | ijjk/next.js fix/initial-trace-items | Change | |
---|---|---|---|
index.html gzip | 540 B | 540 B | ✓ |
link.html gzip | 551 B | 551 B | ✓ |
withRouter.html gzip | 533 B | 533 B | ✓ |
Overall change | 1.62 kB | 1.62 kB | ✓ |
Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary | ijjk/next.js fix/initial-trace-items | Change | |
---|---|---|---|
buildDuration | 8s | 8s | -71ms |
buildDurationCached | 3.9s | 3.9s | |
nodeModulesSize | 181 MB | 181 MB | -66 B |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | ijjk/next.js fix/initial-trace-items | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 3.534 | 3.45 | -0.08 |
/ avg req/sec | 707.37 | 724.56 | +17.19 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 2.011 | 2.043 | |
/error-in-render avg req/sec | 1242.85 | 1223.58 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | ijjk/next.js fix/initial-trace-items | Change | |
---|---|---|---|
675-HASH.js gzip | 13.8 kB | 13.8 kB | ✓ |
770.HASH.js gzip | 178 B | 178 B | ✓ |
framework-HASH.js gzip | 50.7 kB | 50.7 kB | ✓ |
main-HASH.js gzip | 34.9 kB | 34.9 kB | ✓ |
webpack-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
Overall change | 101 kB | 101 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | ijjk/next.js fix/initial-trace-items | Change | |
---|---|---|---|
polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | ijjk/next.js fix/initial-trace-items | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error-HASH.js gzip | 180 B | 180 B | ✓ |
amp-HASH.js gzip | 315 B | 315 B | ✓ |
css-HASH.js gzip | 331 B | 331 B | ✓ |
dynamic-HASH.js gzip | 2.79 kB | 2.79 kB | ✓ |
head-HASH.js gzip | 356 B | 356 B | ✓ |
hooks-HASH.js gzip | 637 B | 637 B | ✓ |
image-HASH.js gzip | 573 B | 573 B | ✓ |
index-HASH.js gzip | 262 B | 262 B | ✓ |
link-HASH.js gzip | 2.2 kB | 2.2 kB | ✓ |
routerDirect..HASH.js gzip | 326 B | 326 B | ✓ |
script-HASH.js gzip | 393 B | 393 B | ✓ |
withRouter-HASH.js gzip | 322 B | 322 B | ✓ |
bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
Overall change | 10.1 kB | 10.1 kB | ✓ |
Client Build Manifests
vercel/next.js canary | ijjk/next.js fix/initial-trace-items | Change | |
---|---|---|---|
_buildManifest.js gzip | 512 B | 512 B | ✓ |
Overall change | 512 B | 512 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | ijjk/next.js fix/initial-trace-items | Change | |
---|---|---|---|
index.html gzip | 537 B | 537 B | ✓ |
link.html gzip | 548 B | 548 B | ✓ |
withRouter.html gzip | 529 B | 529 B | ✓ |
Overall change | 1.61 kB | 1.61 kB | ✓ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we include dependencies in the traces correctly as we ignore initial trace items since we already are aware of them. This removes dependency items from the initial trace list since they are traced correctly without being included there.
Bug
fixes #number
contributing.md