Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swc #29460

Merged
merged 7 commits into from Sep 28, 2021
Merged

Update swc #29460

merged 7 commits into from Sep 28, 2021

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Sep 28, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

This fix includes support for invalid tokens in css, which is required for styled-jsx.
I also added the test case which was failing.

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking merge on recompile of the binaries (will trigger that now)

@ijjk
Copy link
Member

ijjk commented Sep 28, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary kdy1/next.js swc-deps-minifier Change
buildDuration 13.5s 13.4s -144ms
buildDurationCached 3.5s 3.4s -98ms
nodeModulesSize 182 MB 182 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-deps-minifier Change
/ failed reqs 0 0
/ total time (seconds) 2.945 2.928 -0.02
/ avg req/sec 848.99 853.88 +4.89
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.442 1.493 ⚠️ +0.05
/error-in-render avg req/sec 1734.26 1674.5 ⚠️ -59.76
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-deps-minifier Change
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27 kB 27 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.8 kB 70.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-deps-minifier Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-deps-minifier Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.15 kB 4.15 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-deps-minifier Change
_buildManifest.js gzip 494 B 494 B
Overall change 494 B 494 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-deps-minifier Change
index.html gzip 539 B 539 B
link.html gzip 550 B 550 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary kdy1/next.js swc-deps-minifier Change
buildDuration 6.8s 7s ⚠️ +146ms
buildDurationCached 3.4s 3.3s -88ms
nodeModulesSize 182 MB 182 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-deps-minifier Change
/ failed reqs 0 0
/ total time (seconds) 2.937 3.047 ⚠️ +0.11
/ avg req/sec 851.07 820.53 ⚠️ -30.54
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.517 1.493 -0.02
/error-in-render avg req/sec 1647.53 1674.8 +27.27
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-deps-minifier Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.7 kB 50.7 kB
main-HASH.js gzip 34.9 kB 34.9 kB
webpack-HASH.js gzip 1.65 kB 1.65 kB
Overall change 101 kB 101 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-deps-minifier Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-deps-minifier Change
_app-HASH.js gzip 1.32 kB 1.32 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.8 kB 2.8 kB
head-HASH.js gzip 356 B 356 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 573 B 573 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 2.2 kB 2.2 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-deps-minifier Change
_buildManifest.js gzip 511 B 511 B
Overall change 511 B 511 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-deps-minifier Change
index.html gzip 539 B 539 B
link.html gzip 552 B 552 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB
Commit: 5fab08f

@timneutkens timneutkens merged commit b4d6e53 into vercel:canary Sep 28, 2021
@timneutkens timneutkens deleted the swc-deps-minifier branch September 28, 2021 14:38
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants