Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SWC unit test #29466

Merged
merged 1 commit into from Sep 28, 2021
Merged

Fix SWC unit test #29466

merged 1 commit into from Sep 28, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Sep 28, 2021

This fixes the expected output failing slightly from whitespace/; for one of the SWC unit tests.

x-ref: https://github.com/vercel/next.js/runs/3733995930?check_suite_focus=true

@ijjk
Copy link
Member Author

ijjk commented Sep 28, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js fix/swc-test Change
buildDuration 13.6s 13.3s -346ms
buildDurationCached 3.5s 3.3s -154ms
nodeModulesSize 181 MB 181 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/swc-test Change
/ failed reqs 0 0
/ total time (seconds) 2.961 2.985 ⚠️ +0.02
/ avg req/sec 844.45 837.63 ⚠️ -6.82
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.519 1.435 -0.08
/error-in-render avg req/sec 1646.09 1741.9 +95.81
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/swc-test Change
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27 kB 27 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.8 kB 70.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/swc-test Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/swc-test Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.15 kB 4.15 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/swc-test Change
_buildManifest.js gzip 494 B 494 B
Overall change 494 B 494 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/swc-test Change
index.html gzip 540 B 540 B
link.html gzip 551 B 551 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js fix/swc-test Change
buildDuration 7s 6.8s -263ms
buildDurationCached 3.4s 3.4s ⚠️ +21ms
nodeModulesSize 181 MB 181 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/swc-test Change
/ failed reqs 0 0
/ total time (seconds) 2.952 3.028 ⚠️ +0.08
/ avg req/sec 846.74 825.5 ⚠️ -21.24
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.496 1.523 ⚠️ +0.03
/error-in-render avg req/sec 1671.26 1642.02 ⚠️ -29.24
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/swc-test Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.7 kB 50.7 kB
main-HASH.js gzip 34.9 kB 34.9 kB
webpack-HASH.js gzip 1.64 kB 1.64 kB
Overall change 101 kB 101 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/swc-test Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/swc-test Change
_app-HASH.js gzip 1.33 kB 1.33 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.79 kB 2.79 kB
head-HASH.js gzip 356 B 356 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 573 B 573 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 2.2 kB 2.2 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/swc-test Change
_buildManifest.js gzip 512 B 512 B
Overall change 512 B 512 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/swc-test Change
index.html gzip 537 B 537 B
link.html gzip 548 B 548 B
withRouter.html gzip 529 B 529 B
Overall change 1.61 kB 1.61 kB
Commit: 714e506

@ijjk ijjk merged commit f49ff1f into vercel:canary Sep 28, 2021
@ijjk ijjk deleted the fix/swc-test branch September 28, 2021 16:03
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants