Remove error that is too strict in next/dynamic swc transform

[padmaia]

I upgraded swc, which fixes an issue where handled errors were not correctly triggering a Result::Err. I also removed a handler error which was expecting a first argument with a dynamic import call expression, but that doesn't allow for something like:

export function dynamicImport(mod: any) {
  return dynamic(() => handleImport(mod), {
    ssr: false,
  });
}

which would would be a breaking change. Now this example would just not be transformed which is the same behavior as the babel plugin.

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	padmaia/next.js fix/strict-dynamic-error	Change
buildDuration	15.6s	15.5s	-84ms
buildDurationCached	3.9s	3.8s	-101ms
nodeModulesSize	181 MB	181 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	padmaia/next.js fix/strict-dynamic-error	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.59	3.631	⚠️ +0.04
/ avg req/sec	696.38	688.48	⚠️ -7.9
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.89	1.818	-0.07
/error-in-render avg req/sec	1322.59	1375.1	+52.51

Client Bundles (main, webpack, commons)

	vercel/next.js canary	padmaia/next.js fix/strict-dynamic-error	Change
779.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	27 kB	27 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	70.8 kB	70.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	padmaia/next.js fix/strict-dynamic-error	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	padmaia/next.js fix/strict-dynamic-error	Change
_app-HASH.js gzip	977 B	977 B	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	311 B	311 B	✓
css-HASH.js gzip	328 B	328 B	✓
dynamic-HASH.js gzip	2.67 kB	2.67 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	918 B	918 B	✓
image-HASH.js gzip	4.15 kB	4.15 kB	✓
index-HASH.js gzip	260 B	260 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	319 B	319 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	13 kB	13 kB	✓

Client Build Manifests

	vercel/next.js canary	padmaia/next.js fix/strict-dynamic-error	Change
_buildManifest.js gzip	494 B	494 B	✓
Overall change	494 B	494 B	✓

Rendered Page Sizes

	vercel/next.js canary	padmaia/next.js fix/strict-dynamic-error	Change
index.html gzip	538 B	538 B	✓
link.html gzip	550 B	550 B	✓
withRouter.html gzip	532 B	532 B	✓
Overall change	1.62 kB	1.62 kB	✓

---

Default Build with SWC (Increase detected ⚠️)

General

	vercel/next.js canary	padmaia/next.js fix/strict-dynamic-error	Change
buildDuration	8.2s	8.2s	⚠️ +28ms
buildDurationCached	3.9s	3.9s	-86ms
nodeModulesSize	181 MB	181 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	padmaia/next.js fix/strict-dynamic-error	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.775	3.678	-0.1
/ avg req/sec	662.19	679.65	+17.46
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.878	1.845	-0.03
/error-in-render avg req/sec	1331.55	1354.71	+23.16

Client Bundles (main, webpack, commons)

	vercel/next.js canary	padmaia/next.js fix/strict-dynamic-error	Change
675-HASH.js gzip	13.8 kB	13.8 kB	✓
770.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	50.7 kB	50.7 kB	✓
main-HASH.js gzip	34.9 kB	34.9 kB	✓
webpack-HASH.js gzip	1.64 kB	1.64 kB	✓
Overall change	101 kB	101 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	padmaia/next.js fix/strict-dynamic-error	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	padmaia/next.js fix/strict-dynamic-error	Change
_app-HASH.js gzip	1.33 kB	1.33 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	315 B	315 B	✓
css-HASH.js gzip	331 B	331 B	✓
dynamic-HASH.js gzip	2.79 kB	2.79 kB	✓
head-HASH.js gzip	356 B	356 B	✓
hooks-HASH.js gzip	637 B	637 B	✓
image-HASH.js gzip	573 B	573 B	✓
index-HASH.js gzip	262 B	262 B	✓
link-HASH.js gzip	2.2 kB	2.2 kB	✓
routerDirect..HASH.js gzip	326 B	326 B	✓
script-HASH.js gzip	393 B	393 B	✓
withRouter-HASH.js gzip	322 B	322 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	10.1 kB	10.1 kB	✓

Client Build Manifests

	vercel/next.js canary	padmaia/next.js fix/strict-dynamic-error	Change
_buildManifest.js gzip	512 B	512 B	✓
Overall change	512 B	512 B	✓

Rendered Page Sizes

	vercel/next.js canary	padmaia/next.js fix/strict-dynamic-error	Change
index.html gzip	538 B	538 B	✓
link.html gzip	550 B	550 B	✓
withRouter.html gzip	530 B	530 B	✓
Overall change	1.62 kB	1.62 kB	✓

Commit: 4cfd046

[kdy1]

Also LGTM.

[timneutkens]

Awesome 👍