Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade swc deps #29531

Merged
merged 5 commits into from Sep 30, 2021
Merged

Upgrade swc deps #29531

merged 5 commits into from Sep 30, 2021

Conversation

padmaia
Copy link
Member

@padmaia padmaia commented Sep 30, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Sep 30, 2021

Failing test suites

Commit: 29c6f27

test/integration/gssp-ssr-change-reloading/test/index.test.js

  • GS(S)P Server-Side Change Reloading > should not reload page when client-side is changed too GSP
  • GS(S)P Server-Side Change Reloading > should update page when getStaticProps is changed only
  • GS(S)P Server-Side Change Reloading > should show indicator when re-fetching data
  • GS(S)P Server-Side Change Reloading > should update page when getStaticPaths is changed only
  • GS(S)P Server-Side Change Reloading > should not reload page when client-side is changed too GSSP
  • GS(S)P Server-Side Change Reloading > should update page when getServerSideProps is changed only
Expand output

● GS(S)P Server-Side Change Reloading › should not reload page when client-side is changed too GSP

expect(received).toEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  Object {
    "count": 1,
    "params": Object {
      "post": "first",
    },
-   "random": 0.044246752904190334,
+   "random": 0.3990867693660325,
  }

  54 |     await browser.eval(() => (window.beforeChange = 'hi'))
  55 |
> 56 |     const props = JSON.parse(await browser.elementByCss('#props').text())
     |                   ^
  57 |     expect(props.count).toBe(1)
  58 |
  59 |     const page = new File(join(appDir, 'pages/gsp-blog/[post].js'))

  at Object.<anonymous> (integration/gssp-ssr-change-reloading/test/index.test.js:56:19)

● GS(S)P Server-Side Change Reloading › should update page when getStaticProps is changed only

TIMED OUT: 2

1

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (integration/gssp-ssr-change-reloading/test/index.test.js:78:5)

● GS(S)P Server-Side Change Reloading › should show indicator when re-fetching data

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 2

  93 |     expect(await browser.eval(() => window.beforeChange)).toBe('hi')
  94 |     expect(await browser.eval(() => window.showedBuilder)).toBe(true)
> 95 |     page.restore()
     |                 ^
  96 |
  97 |     await check(
  98 |       async () =>

  at Object.<anonymous> (integration/gssp-ssr-change-reloading/test/index.test.js:95:17)

● GS(S)P Server-Side Change Reloading › should update page when getStaticPaths is changed only

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 2

  87 |
  88 |     await check(
> 89 |       async () =>
     |                  ^
  90 |         JSON.parse(await browser.elementByCss('#props').text()).count + '',
  91 |       '2'
  92 |     )

  at Object.<anonymous> (integration/gssp-ssr-change-reloading/test/index.test.js:89:29)

● GS(S)P Server-Side Change Reloading › should not reload page when client-side is changed too GSSP

Failed to replace content.

Pattern: change me

Content: export default function Gssp(props) {
  return (
    <>
      <p id="change">changed</p>
      <p id="props">{JSON.stringify(props)}</p>
    </>
  )
}

export const getServerSideProps = ({ params }) => {
  const count = 2

  return {
    props: {
      count,
      params,
      random: Math.random(),
    },
  }
}

  467 |     } else if (typeof pattern === 'string') {
  468 |       if (!currentContent.includes(pattern)) {
> 469 |         throw new Error(
      |               ^
  470 |           `Failed to replace content.\n\nPattern: ${pattern}\n\nContent: ${currentContent}`
  471 |         )
  472 |       }

  at File.replace (lib/next-test-utils.js:469:15)
  at Object.<anonymous> (integration/gssp-ssr-change-reloading/test/index.test.js:163:63)

● GS(S)P Server-Side Change Reloading › should update page when getServerSideProps is changed only

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 2

  185 |       async () =>
  186 |         JSON.parse(await browser.elementByCss('#props').text()).count + '',
> 187 |       '1'
      |          ^
  188 |     )
  189 |   })
  190 | })

  at Object.<anonymous> (integration/gssp-ssr-change-reloading/test/index.test.js:187:10)

@ijjk
Copy link
Member

ijjk commented Sep 30, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary padmaia/next.js chore/upgrade-swc Change
buildDuration 14.9s 14.7s -177ms
buildDurationCached 3.7s 3.6s -47ms
nodeModulesSize 182 MB 182 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary padmaia/next.js chore/upgrade-swc Change
/ failed reqs 0 0
/ total time (seconds) 3.376 3.53 ⚠️ +0.15
/ avg req/sec 740.43 708.28 ⚠️ -32.15
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.834 1.883 ⚠️ +0.05
/error-in-render avg req/sec 1362.97 1327.94 ⚠️ -35.03
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js chore/upgrade-swc Change
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27 kB 27 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.8 kB 70.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js chore/upgrade-swc Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js chore/upgrade-swc Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.15 kB 4.15 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js chore/upgrade-swc Change
_buildManifest.js gzip 494 B 494 B
Overall change 494 B 494 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js chore/upgrade-swc Change
index.html gzip 538 B 538 B
link.html gzip 550 B 550 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary padmaia/next.js chore/upgrade-swc Change
buildDuration 7.6s 7s -648ms
buildDurationCached 3.7s 3.1s -575ms
nodeModulesSize 182 MB 182 MB
Page Load Tests Overall increase ✓
vercel/next.js canary padmaia/next.js chore/upgrade-swc Change
/ failed reqs 0 0
/ total time (seconds) 3.437 3.15 -0.29
/ avg req/sec 727.28 793.6 +66.32
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.911 1.757 -0.15
/error-in-render avg req/sec 1308.15 1423.03 +114.88
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js chore/upgrade-swc Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.7 kB 50.7 kB
main-HASH.js gzip 35 kB 35 kB
webpack-HASH.js gzip 1.64 kB 1.64 kB
Overall change 101 kB 101 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js chore/upgrade-swc Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js chore/upgrade-swc Change
_app-HASH.js gzip 1.33 kB 1.33 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.79 kB 2.79 kB
head-HASH.js gzip 356 B 356 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 573 B 573 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 2.2 kB 2.2 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js chore/upgrade-swc Change
_buildManifest.js gzip 511 B 511 B
Overall change 511 B 511 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js chore/upgrade-swc Change
index.html gzip 538 B 538 B
link.html gzip 550 B 550 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB
Commit: 26d3db9

@padmaia padmaia merged commit d3b8d70 into vercel:canary Sep 30, 2021
@padmaia padmaia deleted the chore/upgrade-swc branch September 30, 2021 21:21
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants