Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of node-file-trace #29617

Merged
merged 4 commits into from Oct 5, 2021
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 4, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Oct 4, 2021
@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review October 4, 2021 19:38
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Oct 5, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/nft Change
buildDuration 15.5s 15.5s ⚠️ +46ms
buildDurationCached 3.9s 3.7s -159ms
nodeModulesSize 183 MB 183 MB ⚠️ +936 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/nft Change
/ failed reqs 0 0
/ total time (seconds) 3.469 3.495 ⚠️ +0.03
/ avg req/sec 720.66 715.24 ⚠️ -5.42
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.91 1.95 ⚠️ +0.04
/error-in-render avg req/sec 1308.81 1281.78 ⚠️ -27.03
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/nft Change
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 26.9 kB 26.9 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.8 kB 70.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/nft Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/nft Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.15 kB 4.15 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/nft Change
_buildManifest.js gzip 494 B 494 B
Overall change 494 B 494 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/nft Change
index.html gzip 539 B 539 B
link.html gzip 551 B 551 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/nft Change
buildDuration 7.9s 7.9s -11ms
buildDurationCached 3.7s 3.7s -84ms
nodeModulesSize 183 MB 183 MB ⚠️ +936 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/nft Change
/ failed reqs 0 0
/ total time (seconds) 3.412 3.501 ⚠️ +0.09
/ avg req/sec 732.65 714.11 ⚠️ -18.54
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.915 1.887 -0.03
/error-in-render avg req/sec 1305.73 1324.57 +18.84
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/nft Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.7 kB 50.7 kB
main-HASH.js gzip 34.9 kB 34.9 kB
webpack-HASH.js gzip 1.64 kB 1.64 kB
Overall change 101 kB 101 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/nft Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/nft Change
_app-HASH.js gzip 1.33 kB 1.33 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.79 kB 2.79 kB
head-HASH.js gzip 356 B 356 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 573 B 573 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 2.2 kB 2.2 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/nft Change
_buildManifest.js gzip 511 B 511 B
Overall change 511 B 511 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/nft Change
index.html gzip 539 B 539 B
link.html gzip 551 B 551 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB
Commit: 2144973

@ijjk ijjk merged commit 39b30e5 into vercel:canary Oct 5, 2021
@ijjk ijjk deleted the update/nft branch October 5, 2021 14:11
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants