Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar in conflicting paths error #29658

Merged
merged 1 commit into from Oct 6, 2021

Conversation

jonowu
Copy link
Contributor

@jonowu jonowu commented Oct 6, 2021

Updates paths must unique per page to paths must be unique per page.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ijjk
Copy link
Member

ijjk commented Oct 6, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary jonowu/next.js fix-conflicting-paths-grammar Change
buildDuration 13.8s 14.1s ⚠️ +290ms
buildDurationCached 3.6s 3.6s ⚠️ +27ms
nodeModulesSize 193 MB 193 MB ⚠️ +3 B
Page Load Tests Overall increase ✓
vercel/next.js canary jonowu/next.js fix-conflicting-paths-grammar Change
/ failed reqs 0 0
/ total time (seconds) 3.152 3.116 -0.04
/ avg req/sec 793.22 802.41 +9.19
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.511 1.501 -0.01
/error-in-render avg req/sec 1654.71 1665.43 +10.72
Client Bundles (main, webpack, commons)
vercel/next.js canary jonowu/next.js fix-conflicting-paths-grammar Change
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 26.9 kB 26.9 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.8 kB 70.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jonowu/next.js fix-conflicting-paths-grammar Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary jonowu/next.js fix-conflicting-paths-grammar Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.15 kB 4.15 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary jonowu/next.js fix-conflicting-paths-grammar Change
_buildManifest.js gzip 494 B 494 B
Overall change 494 B 494 B
Rendered Page Sizes
vercel/next.js canary jonowu/next.js fix-conflicting-paths-grammar Change
index.html gzip 539 B 539 B
link.html gzip 552 B 552 B
withRouter.html gzip 534 B 534 B
Overall change 1.63 kB 1.63 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary jonowu/next.js fix-conflicting-paths-grammar Change
buildDuration 7.4s 7.4s -10ms
buildDurationCached 3.5s 3.5s -35ms
nodeModulesSize 193 MB 193 MB ⚠️ +3 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary jonowu/next.js fix-conflicting-paths-grammar Change
/ failed reqs 0 0
/ total time (seconds) 3.117 3.202 ⚠️ +0.08
/ avg req/sec 802 780.87 ⚠️ -21.13
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.484 1.483 0
/error-in-render avg req/sec 1684.15 1686.26 +2.11
Client Bundles (main, webpack, commons)
vercel/next.js canary jonowu/next.js fix-conflicting-paths-grammar Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.7 kB 50.7 kB
main-HASH.js gzip 34.9 kB 34.9 kB
webpack-HASH.js gzip 1.64 kB 1.64 kB
Overall change 101 kB 101 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jonowu/next.js fix-conflicting-paths-grammar Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary jonowu/next.js fix-conflicting-paths-grammar Change
_app-HASH.js gzip 1.33 kB 1.33 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.79 kB 2.79 kB
head-HASH.js gzip 356 B 356 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 573 B 573 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 2.2 kB 2.2 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary jonowu/next.js fix-conflicting-paths-grammar Change
_buildManifest.js gzip 511 B 511 B
Overall change 511 B 511 B
Rendered Page Sizes
vercel/next.js canary jonowu/next.js fix-conflicting-paths-grammar Change
index.html gzip 538 B 538 B
link.html gzip 550 B 550 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB
Commit: dc6edc2

@ijjk ijjk merged commit affbc15 into vercel:canary Oct 6, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants