Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styled-jsx): Use correct SyntaxContext for identifiers #29705

Merged
merged 3 commits into from Oct 7, 2021

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 7, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

padmaia
padmaia previously approved these changes Oct 7, 2021
@ijjk
Copy link
Member

ijjk commented Oct 7, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary kdy1/next.js swc-bug Change
buildDuration 16.7s 16.9s ⚠️ +209ms
buildDurationCached 3.8s 4s ⚠️ +191ms
nodeModulesSize 194 MB 194 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-bug Change
/ failed reqs 0 0
/ total time (seconds) 3.778 3.865 ⚠️ +0.09
/ avg req/sec 661.8 646.88 ⚠️ -14.92
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.049 2.091 ⚠️ +0.04
/error-in-render avg req/sec 1220.4 1195.42 ⚠️ -24.98
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-bug Change
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 26.9 kB 26.9 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.8 kB 70.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-bug Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-bug Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.12 kB 4.12 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.9 kB 12.9 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-bug Change
_buildManifest.js gzip 494 B 494 B
Overall change 494 B 494 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-bug Change
index.html gzip 539 B 539 B
link.html gzip 551 B 551 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary kdy1/next.js swc-bug Change
buildDuration 8.5s 8.4s -102ms
buildDurationCached 3.9s 3.9s -90ms
nodeModulesSize 194 MB 194 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-bug Change
/ failed reqs 0 0
/ total time (seconds) 3.935 3.916 -0.02
/ avg req/sec 635.37 638.4 +3.03
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.98 2.058 ⚠️ +0.08
/error-in-render avg req/sec 1262.4 1214.5 ⚠️ -47.9
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-bug Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.7 kB 50.7 kB
main-HASH.js gzip 35 kB 35 kB
webpack-HASH.js gzip 1.64 kB 1.64 kB
Overall change 101 kB 101 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-bug Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-bug Change
_app-HASH.js gzip 1.33 kB 1.33 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.79 kB 2.79 kB
head-HASH.js gzip 356 B 356 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 557 B 557 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 2.22 kB 2.22 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-bug Change
_buildManifest.js gzip 511 B 511 B
Overall change 511 B 511 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-bug Change
index.html gzip 539 B 539 B
link.html gzip 551 B 551 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB
Commit: 0cf49bb

ijjk
ijjk previously approved these changes Oct 7, 2021
@github-actions github-actions bot dismissed stale reviews from ijjk and padmaia via c2f1514 October 7, 2021 15:44
@timneutkens timneutkens merged commit 0a803ba into vercel:canary Oct 7, 2021
@timneutkens timneutkens deleted the swc-bug branch October 7, 2021 16:17
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants