Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix styled-jsx: Don't drop extra selectors #29791

Merged
merged 6 commits into from Oct 11, 2021
Merged

Fix styled-jsx: Don't drop extra selectors #29791

merged 6 commits into from Oct 11, 2021

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 11, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@kdy1 kdy1 marked this pull request as draft October 11, 2021 04:32
@ijjk

This comment has been minimized.

Sign in to view
@kdy1 kdy1 marked this pull request as ready for review October 11, 2021 05:35
@ijjk
Copy link
Member

ijjk commented Oct 11, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary kdy1/next.js swc Change
buildDuration 14.4s 14.4s -17ms
buildDurationCached 3.5s 3.5s -10ms
nodeModulesSize 195 MB 195 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.236 3.274 ⚠️ +0.04
/ avg req/sec 772.47 763.69 ⚠️ -8.78
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.547 1.515 -0.03
/error-in-render avg req/sec 1616.2 1649.79 +33.59
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc Change
779.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 26.9 kB 26.9 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 70.8 kB 70.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kdy1/next.js swc Change
_app-HASH.js gzip 977 B 977 B ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 311 B 311 B ✓
css-HASH.js gzip 328 B 328 B ✓
dynamic-HASH.js gzip 2.67 kB 2.67 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 918 B 918 B ✓
image-HASH.js gzip 4.12 kB 4.12 kB ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 319 B 319 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 12.9 kB 12.9 kB ✓
Client Build Manifests
vercel/next.js canary kdy1/next.js swc Change
_buildManifest.js gzip 494 B 494 B ✓
Overall change 494 B 494 B ✓
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc Change
index.html gzip 538 B 538 B ✓
link.html gzip 550 B 550 B ✓
withRouter.html gzip 532 B 532 B ✓
Overall change 1.62 kB 1.62 kB ✓
Default Build with SWC
General
vercel/next.js canary kdy1/next.js swc Change
buildDuration 7.3s 7.3s ⚠️ +22ms
buildDurationCached 3.6s 3.4s -218ms
nodeModulesSize 195 MB 195 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.248 3.236 -0.01
/ avg req/sec 769.74 772.59 +2.85
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.498 1.5 0
/error-in-render avg req/sec 1668.95 1666.12 ⚠️ -2.83
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc Change
675-HASH.js gzip 13.8 kB 13.8 kB ✓
770.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 50.7 kB 50.7 kB ✓
main-HASH.js gzip 35 kB 35 kB ✓
webpack-HASH.js gzip 1.64 kB 1.64 kB ✓
Overall change 101 kB 101 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kdy1/next.js swc Change
_app-HASH.js gzip 1.33 kB 1.33 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 315 B 315 B ✓
css-HASH.js gzip 331 B 331 B ✓
dynamic-HASH.js gzip 2.79 kB 2.79 kB ✓
head-HASH.js gzip 355 B 355 B ✓
hooks-HASH.js gzip 637 B 637 B ✓
image-HASH.js gzip 555 B 555 B ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.22 kB 2.22 kB ✓
routerDirect..HASH.js gzip 326 B 326 B ✓
script-HASH.js gzip 393 B 393 B ✓
withRouter-HASH.js gzip 322 B 322 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 10.1 kB 10.1 kB ✓
Client Build Manifests
vercel/next.js canary kdy1/next.js swc Change
_buildManifest.js gzip 511 B 511 B ✓
Overall change 511 B 511 B ✓
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc Change
index.html gzip 538 B 538 B ✓
link.html gzip 551 B 551 B ✓
withRouter.html gzip 533 B 533 B ✓
Overall change 1.62 kB 1.62 kB ✓
Commit: fe2afeb

@ijjk
Copy link
Member

ijjk commented Oct 11, 2021

Failing test suites

Commit: fe2afeb

test/development/basic/hmr.test.ts

  • basic HMR > Error Recovery > should recover after exporting an invalid page
  • basic HMR > Error Recovery > should recover after a bad return from the render function
  • basic HMR > Error Recovery > should recover after undefined exported as default
  • basic HMR > Error Recovery > should recover after an error reported via SSR
Expand output

● basic HMR › Error Recovery › should recover after exporting an invalid page

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:510:9)

● basic HMR › Error Recovery › should recover after exporting an invalid page

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `basic HMR Error Recovery should recover after exporting an invalid page 1`

- Snapshot  - 3
+ Received  + 1

   1 of 1 unhandled error
- Server Error
+ Unhandled Runtime Error

  Error: The default export is not a React Component in page: "/hmr/about5"
-
- This error happened while generating the page. Any console logs will be displayed in the terminal window.

  488 |
  489 |         expect(await hasRedbox(browser)).toBe(true)
> 490 |         expect(await getRedboxHeader(browser)).toMatchInlineSnapshot(`
      |                                                ^
  491 |           " 1 of 1 unhandled error
  492 |           Server Error
  493 |

  at Object.<anonymous> (development/basic/hmr.test.ts:490:48)

● basic HMR › Error Recovery › should recover after a bad return from the render function

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:558:9)

● basic HMR › Error Recovery › should recover after undefined exported as default

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `basic HMR Error Recovery should recover after undefined exported as default 1`

- Snapshot  - 3
+ Received  + 1

   1 of 1 unhandled error
- Server Error
+ Unhandled Runtime Error

  Error: The default export is not a React Component in page: "/hmr/about7"
-
- This error happened while generating the page. Any console logs will be displayed in the terminal window.

  600 |         await next.patchFile(aboutPage, aboutContent)
  601 |
> 602 |         if (browser) {
      |                       ^
  603 |           await check(
  604 |             () => getBrowserBodyText(browser),
  605 |             /This is the about page/

  at Object.<anonymous> (development/basic/hmr.test.ts:602:23)

● basic HMR › Error Recovery › should recover after an error reported via SSR

TIMED OUT: /Hello/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:489:17)

@timneutkens timneutkens merged commit 2874791 into vercel:canary Oct 11, 2021
@timneutkens timneutkens deleted the swc branch October 11, 2021 06:36
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@styfle styfle Awaiting requested review from styfle

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kdy1 @ijjk @styfle @timneutkens