Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade strip-ansi in react-dev-overlay #29906

Merged
merged 4 commits into from Oct 14, 2021

Conversation

thibautsabot
Copy link
Contributor

Fixes #29429

timneutkens
timneutkens previously approved these changes Oct 14, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ijjk
Copy link
Member

ijjk commented Oct 14, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary thibautsabot/next.js upgrade-strip-ansi Change
buildDuration 12s 12s -58ms
buildDurationCached 3s 2.9s -117ms
nodeModulesSize 200 MB 200 MB ⚠️ +1 B
Page Load Tests Overall increase ✓
vercel/next.js canary thibautsabot/next.js upgrade-strip-ansi Change
/ failed reqs 0 0
/ total time (seconds) 2.826 2.741 -0.08
/ avg req/sec 884.62 912.11 +27.49
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.256 1.25 -0.01
/error-in-render avg req/sec 1990.31 2000.39 +10.08
Client Bundles (main, webpack, commons)
vercel/next.js canary thibautsabot/next.js upgrade-strip-ansi Change
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27 kB 27 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.9 kB 70.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary thibautsabot/next.js upgrade-strip-ansi Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary thibautsabot/next.js upgrade-strip-ansi Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary thibautsabot/next.js upgrade-strip-ansi Change
_buildManifest.js gzip 493 B 493 B
Overall change 493 B 493 B
Rendered Page Sizes
vercel/next.js canary thibautsabot/next.js upgrade-strip-ansi Change
index.html gzip 538 B 538 B
link.html gzip 550 B 550 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary thibautsabot/next.js upgrade-strip-ansi Change
buildDuration 6.1s 6.1s ⚠️ +20ms
buildDurationCached 3s 3s ⚠️ +9ms
nodeModulesSize 200 MB 200 MB ⚠️ +1 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary thibautsabot/next.js upgrade-strip-ansi Change
/ failed reqs 0 0
/ total time (seconds) 2.875 2.806 -0.07
/ avg req/sec 869.59 890.98 +21.39
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.243 1.267 ⚠️ +0.02
/error-in-render avg req/sec 2011.96 1972.83 ⚠️ -39.13
Client Bundles (main, webpack, commons)
vercel/next.js canary thibautsabot/next.js upgrade-strip-ansi Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.8 kB 50.8 kB
main-HASH.js gzip 35.1 kB 35.1 kB
webpack-HASH.js gzip 1.64 kB 1.64 kB
Overall change 101 kB 101 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary thibautsabot/next.js upgrade-strip-ansi Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary thibautsabot/next.js upgrade-strip-ansi Change
_app-HASH.js gzip 1.33 kB 1.33 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.79 kB 2.79 kB
head-HASH.js gzip 355 B 355 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 555 B 555 B
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.22 kB 2.22 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary thibautsabot/next.js upgrade-strip-ansi Change
_buildManifest.js gzip 511 B 511 B
Overall change 511 B 511 B
Rendered Page Sizes
vercel/next.js canary thibautsabot/next.js upgrade-strip-ansi Change
index.html gzip 538 B 538 B
link.html gzip 551 B 551 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB
Commit: e942cc9

@ijjk

This comment has been minimized.

@ijjk ijjk merged commit ba39ee4 into vercel:canary Oct 14, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants