Update swc #29913

kdy1 · 2021-10-14T13:50:04Z

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes

styfle

Did you intend to only update the lock file?

ijjk · 2021-10-14T14:06:29Z

Failing test suites

Commit: 6a15808

test/development/basic/hmr.test.ts

basic HMR > Error Recovery > should detect runtime errors on the module scope
basic HMR > Error Recovery > should recover after a bad return from the render function
basic HMR > Error Recovery > should recover after undefined exported as default
basic HMR > Error Recovery > should recover after an error reported via SSR

Expand output

● basic HMR › Error Recovery › should detect runtime errors on the module scope

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:425:9)

● basic HMR › Error Recovery › should recover after a bad return from the render function

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:558:9)

● basic HMR › Error Recovery › should recover after undefined exported as default

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:614:8)

● basic HMR › Error Recovery › should recover after an error reported via SSR

TIMED OUT: /Hello/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:489:17)

ijjk · 2021-10-14T14:55:26Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	kdy1/next.js swc-ver	Change
buildDuration	13.3s	14.1s	⚠️ +727ms
buildDurationCached	3.4s	3.1s	-299ms
nodeModulesSize	200 MB	200 MB	-12 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	kdy1/next.js swc-ver	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.273	3.357	⚠️ +0.08
/ avg req/sec	763.91	744.63	⚠️ -19.28
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.778	1.691	-0.09
/error-in-render avg req/sec	1405.88	1478.67	+72.79

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kdy1/next.js swc-ver	Change
779.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	27 kB	27 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	70.9 kB	70.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kdy1/next.js swc-ver	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	kdy1/next.js swc-ver	Change
_app-HASH.js gzip	977 B	977 B	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	311 B	311 B	✓
css-HASH.js gzip	328 B	328 B	✓
dynamic-HASH.js gzip	2.67 kB	2.67 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	918 B	918 B	✓
image-HASH.js gzip	4.14 kB	4.14 kB	✓
index-HASH.js gzip	260 B	260 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	319 B	319 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	13 kB	13 kB	✓

Client Build Manifests

	vercel/next.js canary	kdy1/next.js swc-ver	Change
_buildManifest.js gzip	493 B	493 B	✓
Overall change	493 B	493 B	✓

Rendered Page Sizes

	vercel/next.js canary	kdy1/next.js swc-ver	Change
index.html gzip	538 B	538 B	✓
link.html gzip	550 B	550 B	✓
withRouter.html gzip	533 B	533 B	✓
Overall change	1.62 kB	1.62 kB	✓

Default Build with SWC (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	kdy1/next.js swc-ver	Change
buildDuration	6.7s	6.4s	-307ms
buildDurationCached	3s	3.2s	⚠️ +145ms
nodeModulesSize	200 MB	200 MB	-12 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	kdy1/next.js swc-ver	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.262	3.112	-0.15
/ avg req/sec	766.41	803.39	+36.98
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.729	1.546	-0.18
/error-in-render avg req/sec	1446.05	1617.47	+171.42

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	kdy1/next.js swc-ver	Change
675-HASH.js gzip	13.8 kB	13.8 kB	⚠️ +29 B
770.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	50.7 kB	50.8 kB	⚠️ +31 B
main-HASH.js gzip	35 kB	35.1 kB	⚠️ +34 B
webpack-HASH.js gzip	1.64 kB	1.64 kB	✓
Overall change	101 kB	101 kB	⚠️ +94 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kdy1/next.js swc-ver	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	kdy1/next.js swc-ver	Change
_app-HASH.js gzip	1.33 kB	1.33 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	315 B	315 B	✓
css-HASH.js gzip	331 B	331 B	✓
dynamic-HASH.js gzip	2.79 kB	2.79 kB	✓
head-HASH.js gzip	355 B	355 B	✓
hooks-HASH.js gzip	637 B	637 B	✓
image-HASH.js gzip	555 B	555 B	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	2.22 kB	2.22 kB	✓
routerDirect..HASH.js gzip	326 B	326 B	✓
script-HASH.js gzip	393 B	393 B	✓
withRouter-HASH.js gzip	322 B	322 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	10.1 kB	10.1 kB	✓

Client Build Manifests Overall decrease ✓

	vercel/next.js canary	kdy1/next.js swc-ver	Change
_buildManifest.js gzip	512 B	511 B	-1 B
Overall change	512 B	511 B	-1 B

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	kdy1/next.js swc-ver	Change
index.html gzip	538 B	538 B	✓
link.html gzip	552 B	551 B	-1 B
withRouter.html gzip	533 B	532 B	-1 B
Overall change	1.62 kB	1.62 kB	-2 B

Commit: a14f9a9

Update swc

6a15808

kdy1 requested review from huozhi, ijjk, padmaia, shuding, styfle and timneutkens as code owners October 14, 2021 13:50

ijjk added the type: next label Oct 14, 2021

styfle previously approved these changes Oct 14, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

Build next-swc binaries

a109907

github-actions bot dismissed styfle’s stale review via a109907 October 14, 2021 14:18

ijjk approved these changes Oct 14, 2021

View reviewed changes

Merge branch 'canary' into swc-ver

a14f9a9

kodiakhq bot merged commit e45d138 into vercel:canary Oct 14, 2021

kdy1 deleted the swc-ver branch October 14, 2021 15:30

styfle added the hacktoberfest-accepted label Oct 15, 2021

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update swc #29913

Update swc #29913

kdy1 commented Oct 14, 2021

styfle left a comment

This comment has been minimized.

ijjk commented Oct 14, 2021

ijjk commented Oct 14, 2021

Update swc #29913

Update swc #29913

Conversation

kdy1 commented Oct 14, 2021

Bug

Feature

Documentation / Examples

styfle left a comment

Choose a reason for hiding this comment

This comment has been minimized.

ijjk commented Oct 14, 2021

Failing test suites

ijjk commented Oct 14, 2021

Stats from current PR