fix(examples/with-docker): update env comments #29972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KateKate
requested review from
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
KateKate
force-pushed
the
example-with-docker-telemetry
branch
from
5f6ede3
to
c543546
Compare
# Conflicts: # examples/with-docker/Dockerfile
ijjk
changed the title
natew
pushed a commit
to natew/next.js
that referenced
this pull request
Feb 16, 2022
This fixes the comment about disabling telemetry. For now it doesn't disable telemetry for `next build` if you uncomment it. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the comment about disabling telemetry. For now it doesn't disable telemetry for
next buildif you uncomment it.Bug
fixes #numbercontributing.mdFeature
fixes #numbercontributing.mdDocumentation / Examples