Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update swc to fix minifier #29989

Merged
merged 2 commits into from Oct 17, 2021
Merged

Update swc to fix minifier #29989

merged 2 commits into from Oct 17, 2021

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 17, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member

ijjk commented Oct 17, 2021

Stats from current PR

Default Build
General
vercel/next.js canary kdy1/next.js swc-ver-4 Change
buildDuration 12.5s 12.4s -140ms
buildDurationCached 3s 2.9s -65ms
nodeModulesSize 198 MB 198 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-ver-4 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.806 2.804 0
/ avg req/sec 890.97 891.73 +0.76
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.277 1.276 0
/error-in-render avg req/sec 1957 1959.06 +2.06
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-ver-4 Change
558.HASH.js gzip 3.02 kB 3.02 kB ✓
779.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 25 kB 25 kB ✓
webpack-HASH.js gzip 1.49 kB 1.49 kB ✓
Overall change 71.9 kB 71.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-ver-4 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kdy1/next.js swc-ver-4 Change
_app-HASH.js gzip 977 B 977 B ✓
_error-HASH.js gzip 3.11 kB 3.11 kB ✓
amp-HASH.js gzip 553 B 553 B ✓
css-HASH.js gzip 328 B 328 B ✓
dynamic-HASH.js gzip 2.73 kB 2.73 kB ✓
head-HASH.js gzip 2.37 kB 2.37 kB ✓
hooks-HASH.js gzip 918 B 918 B ✓
image-HASH.js gzip 5.86 kB 5.86 kB ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 319 B 319 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 19.9 kB 19.9 kB ✓
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-ver-4 Change
_buildManifest.js gzip 490 B 490 B ✓
Overall change 490 B 490 B ✓
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-ver-4 Change
index.html gzip 538 B 538 B ✓
link.html gzip 550 B 550 B ✓
withRouter.html gzip 531 B 531 B ✓
Overall change 1.62 kB 1.62 kB ✓
Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary kdy1/next.js swc-ver-4 Change
buildDuration 6.1s 6.1s ⚠️ +44ms
buildDurationCached 2.9s 2.8s -57ms
nodeModulesSize 198 MB 198 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-ver-4 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.83 2.867 ⚠️ +0.04
/ avg req/sec 883.37 871.95 ⚠️ -11.42
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.272 1.286 ⚠️ +0.01
/error-in-render avg req/sec 1965.24 1944.41 ⚠️ -20.83
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-ver-4 Change
675-HASH.js gzip 13.8 kB 13.8 kB ✓
770.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 50.8 kB 50.8 kB ✓
main-HASH.js gzip 35.2 kB 35.2 kB ✓
webpack-HASH.js gzip 1.64 kB 1.64 kB ✓
Overall change 102 kB 102 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-ver-4 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kdy1/next.js swc-ver-4 Change
_app-HASH.js gzip 1.33 kB 1.33 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 315 B 315 B ✓
css-HASH.js gzip 331 B 331 B ✓
dynamic-HASH.js gzip 2.79 kB 2.79 kB ✓
head-HASH.js gzip 355 B 355 B ✓
hooks-HASH.js gzip 637 B 637 B ✓
image-HASH.js gzip 555 B 555 B ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.22 kB 2.22 kB ✓
routerDirect..HASH.js gzip 326 B 326 B ✓
script-HASH.js gzip 393 B 393 B ✓
withRouter-HASH.js gzip 322 B 322 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 10.1 kB 10.1 kB ✓
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-ver-4 Change
_buildManifest.js gzip 510 B 510 B ✓
Overall change 510 B 510 B ✓
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-ver-4 Change
index.html gzip 540 B 540 B ✓
link.html gzip 552 B 552 B ✓
withRouter.html gzip 533 B 533 B ✓
Overall change 1.63 kB 1.63 kB ✓
Commit: 1da26e0

@ijjk
Copy link
Member

ijjk commented Oct 17, 2021

Failing test suites

Commit: 1da26e0

test/development/basic/hmr.test.ts

  • basic HMR > Error Recovery > should detect runtime errors on the module scope
  • basic HMR > Error Recovery > should recover from errors in the render function
  • basic HMR > Error Recovery > should recover after exporting an invalid page
  • basic HMR > Error Recovery > should recover after a bad return from the render function
  • basic HMR > Error Recovery > should recover after undefined exported as default
Expand output

● basic HMR › Error Recovery › should detect runtime errors on the module scope

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:425:9)

● basic HMR › Error Recovery › should recover from errors in the render function

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:455:9)

● basic HMR › Error Recovery › should recover after exporting an invalid page

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:510:9)

● basic HMR › Error Recovery › should recover after a bad return from the render function

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:558:9)

● basic HMR › Error Recovery › should recover after undefined exported as default

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `basic HMR Error Recovery should recover after undefined exported as default 1`

- Snapshot  - 3
+ Received  + 1

   1 of 1 unhandled error
- Server Error
+ Unhandled Runtime Error

  Error: The default export is not a React Component in page: "/hmr/about7"
-
- This error happened while generating the page. Any console logs will be displayed in the terminal window.

  600 |         await next.patchFile(aboutPage, aboutContent)
  601 |
> 602 |         if (browser) {
      |                       ^
  603 |           await check(
  604 |             () => getBrowserBodyText(browser),
  605 |             /This is the about page/

  at Object.<anonymous> (development/basic/hmr.test.ts:602:23)

@timneutkens timneutkens merged commit 9885ab6 into vercel:canary Oct 17, 2021
@timneutkens timneutkens deleted the swc-ver-4 branch October 17, 2021 14:25
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@styfle styfle Awaiting requested review from styfle

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kdy1 @ijjk @styfle @timneutkens