Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify export statement #30015

Merged
merged 5 commits into from Oct 21, 2021
Merged

Simplify export statement #30015

merged 5 commits into from Oct 21, 2021

Conversation

roj1512
Copy link
Contributor

@roj1512 roj1512 commented Oct 18, 2021

No description provided.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Oct 20, 2021

Failing test suites

Commit: 51068d3

test/development/basic/hmr.test.ts

  • basic HMR > Error Recovery > should detect runtime errors on the module scope
  • basic HMR > Error Recovery > should recover after undefined exported as default
Expand output

● basic HMR › Error Recovery › should detect runtime errors on the module scope

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:425:9)

● basic HMR › Error Recovery › should recover after undefined exported as default

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:614:8)

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Oct 21, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary rojserbest/next.js patch-1 Change
buildDuration 16.7s 16.6s -157ms
buildDurationCached 3.8s 3.6s -225ms
nodeModulesSize 195 MB 195 MB -66 B
Page Load Tests Overall increase ✓
vercel/next.js canary rojserbest/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 4.002 4.03 ⚠️ +0.03
/ avg req/sec 624.68 620.29 ⚠️ -4.39
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.093 2.082 -0.01
/error-in-render avg req/sec 1194.54 1200.64 +6.1
Client Bundles (main, webpack, commons)
vercel/next.js canary rojserbest/next.js patch-1 Change
651.cd440d20..0b23.js gzip 2.96 kB 2.96 kB
831.695e33f6..205f.js gzip 179 B 179 B
framework-89..a097.js gzip 42.2 kB 42.2 kB
main-45201df..96b4.js gzip 26.1 kB 26.1 kB
webpack-f09b..493e.js gzip 1.47 kB 1.47 kB
Overall change 73 kB 73 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary rojserbest/next.js patch-1 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary rojserbest/next.js patch-1 Change
_app-9fb8765..c13d.js gzip 979 B 979 B
_error-d828d..2954.js gzip 3.06 kB 3.06 kB
amp-5388d1f5..4ce9.js gzip 551 B 551 B
css-10424225..367a.js gzip 329 B 329 B
dynamic-9821..3cd4.js gzip 2.67 kB 2.67 kB
head-1df323b..d261.js gzip 2.32 kB 2.32 kB
hooks-ab0016..b093.js gzip 917 B 917 B
image-c3cc30..4e2a.js gzip 5.87 kB 5.87 kB
index-95c8cb..6970.js gzip 260 B 260 B
link-05c99e7..35ec.js gzip 1.66 kB 1.66 kB
routerDirect..6659.js gzip 319 B 319 B
script-d94ba..ed05.js gzip 386 B 386 B
withRouter-7..8b2e.js gzip 317 B 317 B
9a34b27eb3f9..27d.css gzip 125 B 125 B
Overall change 19.8 kB 19.8 kB
Client Build Manifests
vercel/next.js canary rojserbest/next.js patch-1 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary rojserbest/next.js patch-1 Change
index.html gzip 537 B 537 B
link.html gzip 549 B 549 B
withRouter.html gzip 529 B 529 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary rojserbest/next.js patch-1 Change
buildDuration 7.8s 7.7s -41ms
buildDurationCached 3.5s 3.7s ⚠️ +148ms
nodeModulesSize 195 MB 195 MB -66 B
Page Load Tests Overall increase ✓
vercel/next.js canary rojserbest/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 3.956 3.928 -0.03
/ avg req/sec 631.88 636.42 +4.54
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.117 2.033 -0.08
/error-in-render avg req/sec 1181.03 1230.01 +48.98
Client Bundles (main, webpack, commons)
vercel/next.js canary rojserbest/next.js patch-1 Change
450.fd3ad245..022b.js gzip 179 B 179 B
675-f623fa2a..036a.js gzip 13.9 kB 13.9 kB
framework-13..70b0.js gzip 50.8 kB 50.8 kB
main-1e4b9db..ad07.js gzip 36.5 kB 36.5 kB
webpack-a7f2..2650.js gzip 1.63 kB 1.63 kB
Overall change 103 kB 103 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary rojserbest/next.js patch-1 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary rojserbest/next.js patch-1 Change
_app-ae91bc3..d985.js gzip 1.33 kB 1.33 kB
_error-273ac..9ef0.js gzip 180 B 180 B
amp-5f9a7694..99ce.js gzip 315 B 315 B
css-3a1b2477..df1e.js gzip 330 B 330 B
dynamic-8d0e..e365.js gzip 2.79 kB 2.79 kB
head-7f600d0..daa3.js gzip 356 B 356 B
hooks-bd8c02..0730.js gzip 638 B 638 B
image-16df09..4584.js gzip 555 B 555 B
index-80be94..e89f.js gzip 262 B 262 B
link-4ee1ea7..8745.js gzip 2.22 kB 2.22 kB
routerDirect..c4aa.js gzip 325 B 325 B
script-67da0..49e6.js gzip 390 B 390 B
withRouter-2..2409.js gzip 322 B 322 B
9a34b27eb3f9..27d.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary rojserbest/next.js patch-1 Change
_buildManifest.js gzip 476 B 476 B
Overall change 476 B 476 B
Rendered Page Sizes
vercel/next.js canary rojserbest/next.js patch-1 Change
index.html gzip 534 B 534 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 81b9d73

@kodiakhq kodiakhq bot merged commit dd81d2c into vercel:canary Oct 21, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants