Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react 18 streaming api #30038

Merged
merged 6 commits into from Oct 18, 2021
Merged

Update react 18 streaming api #30038

merged 6 commits into from Oct 18, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Oct 18, 2021

Update steaming api based on reactwg group announcement

pipeToNodeWritable(children, writable, options).startWriting(); it is now renderToPipeableStream(children, options).pipe(writable)

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Oct 18, 2021

Failing test suites

Commit: 76d02c4

test/development/basic-basepath/hmr.test.ts

  • basic HMR > Error Recovery > should recover after a bad return from the render function
Expand output

● basic HMR › Error Recovery › should recover after a bad return from the render function

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic-basepath/hmr.test.ts:561:9)

@ijjk
Copy link
Member

ijjk commented Oct 18, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js update-react-rsc-api Change
buildDuration 17.3s 17.2s -82ms
buildDurationCached 3.9s 4s ⚠️ +100ms
nodeModulesSize 195 MB 195 MB ⚠️ +56 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js update-react-rsc-api Change
/ failed reqs 0 0
/ total time (seconds) 3.971 4.08 ⚠️ +0.11
/ avg req/sec 629.63 612.71 ⚠️ -16.92
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.098 1.984 -0.11
/error-in-render avg req/sec 1191.66 1260.01 +68.35
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js update-react-rsc-api Change
558.HASH.js gzip 3.02 kB 3.02 kB
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 25 kB 25 kB
webpack-HASH.js gzip 1.49 kB 1.49 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js update-react-rsc-api Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js update-react-rsc-api Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 3.11 kB 3.11 kB
amp-HASH.js gzip 553 B 553 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.73 kB 2.73 kB
head-HASH.js gzip 2.37 kB 2.37 kB
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 5.85 kB 5.85 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 19.9 kB 19.9 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js update-react-rsc-api Change
_buildManifest.js gzip 493 B 493 B
Overall change 493 B 493 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js update-react-rsc-api Change
index.html gzip 539 B 539 B
link.html gzip 550 B 550 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js update-react-rsc-api Change
buildDuration 8.3s 8.5s ⚠️ +170ms
buildDurationCached 4s 3.9s -95ms
nodeModulesSize 195 MB 195 MB ⚠️ +56 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js update-react-rsc-api Change
/ failed reqs 0 0
/ total time (seconds) 4.047 4.068 ⚠️ +0.02
/ avg req/sec 617.77 614.55 ⚠️ -3.22
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.071 2.055 -0.02
/error-in-render avg req/sec 1207.35 1216.44 +9.09
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js update-react-rsc-api Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.8 kB 50.8 kB
main-HASH.js gzip 35.2 kB 35.2 kB
webpack-HASH.js gzip 1.64 kB 1.64 kB
Overall change 102 kB 102 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js update-react-rsc-api Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js update-react-rsc-api Change
_app-HASH.js gzip 1.33 kB 1.33 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.79 kB 2.79 kB
head-HASH.js gzip 355 B 355 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 555 B 555 B
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.22 kB 2.22 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js update-react-rsc-api Change
_buildManifest.js gzip 511 B 511 B
Overall change 511 B 511 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js update-react-rsc-api Change
index.html gzip 539 B 539 B
link.html gzip 552 B 552 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB
Commit: 76d02c4

@ijjk ijjk merged commit 33c687a into vercel:canary Oct 18, 2021
@huozhi huozhi deleted the update-react-rsc-api branch October 19, 2021 07:55
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants