Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint loading on Windows #30040

Merged
merged 1 commit into from Oct 18, 2021
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 18, 2021

This fixes the failing Azure tests from import being used to load eslint with an absolute path:

error - ESLint: Only file and data URLs are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'c:'

@ijjk
Copy link
Member Author

ijjk commented Oct 18, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/eslint-windows Change
buildDuration 13.7s 14.1s ⚠️ +366ms
buildDurationCached 3.3s 3.2s -146ms
nodeModulesSize 195 MB 195 MB ⚠️ +23 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/eslint-windows Change
/ failed reqs 0 0
/ total time (seconds) 3.162 3.178 ⚠️ +0.02
/ avg req/sec 790.57 786.68 ⚠️ -3.89
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.423 1.425 0
/error-in-render avg req/sec 1757.46 1753.94 ⚠️ -3.52
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/eslint-windows Change
558.HASH.js gzip 3.02 kB 3.02 kB
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 25 kB 25 kB
webpack-HASH.js gzip 1.49 kB 1.49 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/eslint-windows Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/eslint-windows Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 3.11 kB 3.11 kB
amp-HASH.js gzip 553 B 553 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.73 kB 2.73 kB
head-HASH.js gzip 2.37 kB 2.37 kB
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 5.86 kB 5.86 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 19.9 kB 19.9 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/eslint-windows Change
_buildManifest.js gzip 490 B 490 B
Overall change 490 B 490 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/eslint-windows Change
index.html gzip 539 B 539 B
link.html gzip 551 B 551 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/eslint-windows Change
buildDuration 6.9s 6.8s -31ms
buildDurationCached 3.3s 3.2s -108ms
nodeModulesSize 195 MB 195 MB ⚠️ +23 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/eslint-windows Change
/ failed reqs 0 0
/ total time (seconds) 3.189 3.202 ⚠️ +0.01
/ avg req/sec 783.93 780.77 ⚠️ -3.16
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.442 1.422 -0.02
/error-in-render avg req/sec 1733.83 1757.63 +23.8
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/eslint-windows Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.8 kB 50.8 kB
main-HASH.js gzip 35.2 kB 35.2 kB
webpack-HASH.js gzip 1.64 kB 1.64 kB
Overall change 102 kB 102 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/eslint-windows Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/eslint-windows Change
_app-HASH.js gzip 1.33 kB 1.33 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.79 kB 2.79 kB
head-HASH.js gzip 355 B 355 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 555 B 555 B
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.22 kB 2.22 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/eslint-windows Change
_buildManifest.js gzip 510 B 510 B
Overall change 510 B 510 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/eslint-windows Change
index.html gzip 538 B 538 B
link.html gzip 551 B 551 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB
Commit: df774bf

@kodiakhq kodiakhq bot merged commit dfd4069 into vercel:canary Oct 18, 2021
@ijjk ijjk deleted the fix/eslint-windows branch October 18, 2021 19:10
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants