Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pageKey and compiling output for on-demand-entries #30116

Merged
merged 7 commits into from Oct 21, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Oct 20, 2021

shows compiling /_error... instead of compiling /next/dist/pages/_error...

ijjk
ijjk previously approved these changes Oct 20, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Oct 20, 2021

Failing test suites

Commit: 1703c2a

test/e2e/basepath.test.ts

  • basePath > should navigate to nested index page with getStaticProps
Expand output

● basePath › should navigate to nested index page with getStaticProps

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for selector "#prop"
============================================================

  201 |     return this.chain(() => {
  202 |       return page
> 203 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  204 |         .then(async (el) => {
  205 |           // it seems selenium waits longer and tests rely on this behavior
  206 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:203:10

test/integration/route-indexes/test/index.test.js

  • Route indexes handling > dev mode > should handle /nested-index/index correctly
Expand output

● Route indexes handling › dev mode › should handle /nested-index/index correctly

expect(received).toBe(expected) // Object.is equality

Expected: 200
Received: 404

  42 |   it('should handle /nested-index/index correctly', async () => {
  43 |     const res = await fetchViaHTTP(appPort, '/nested-index/index')
> 44 |     expect(res.status).toBe(200)
     |                        ^
  45 |     expect(await res.text()).toContain('hello from nested index')
  46 |   })
  47 |

  at Object.<anonymous> (integration/route-indexes/test/index.test.js:44:24)

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Oct 21, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js bugfix/correct-page-key Change
buildDuration 14.9s 14.7s -166ms
buildDurationCached 3.5s 3.4s -73ms
nodeModulesSize 196 MB 196 MB ⚠️ +305 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js bugfix/correct-page-key Change
/ failed reqs 0 0
/ total time (seconds) 3.788 3.665 -0.12
/ avg req/sec 659.9 682.16 +22.26
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.964 1.955 -0.01
/error-in-render avg req/sec 1272.63 1279.06 +6.43
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bugfix/correct-page-key Change
651.cd440d20..0b23.js gzip 2.96 kB 2.96 kB
831.695e33f6..205f.js gzip 179 B 179 B
framework-89..a097.js gzip 42.2 kB 42.2 kB
main-a993820..123b.js gzip 26.1 kB 26.1 kB
webpack-f09b..493e.js gzip 1.47 kB 1.47 kB
Overall change 73 kB 73 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/correct-page-key Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js bugfix/correct-page-key Change
_app-9fb8765..c13d.js gzip 979 B 979 B
_error-d828d..2954.js gzip 3.06 kB 3.06 kB
amp-5388d1f5..4ce9.js gzip 551 B 551 B
css-10424225..367a.js gzip 329 B 329 B
dynamic-9821..3cd4.js gzip 2.67 kB 2.67 kB
head-1df323b..d261.js gzip 2.32 kB 2.32 kB
hooks-ab0016..b093.js gzip 917 B 917 B
image-c3cc30..4e2a.js gzip 5.87 kB 5.87 kB
index-95c8cb..6970.js gzip 260 B 260 B
link-05c99e7..35ec.js gzip 1.66 kB 1.66 kB
routerDirect..6659.js gzip 319 B 319 B
script-d94ba..ed05.js gzip 386 B 386 B
withRouter-7..8b2e.js gzip 317 B 317 B
9a34b27eb3f9..27d.css gzip 125 B 125 B
Overall change 19.8 kB 19.8 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/correct-page-key Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bugfix/correct-page-key Change
index.html gzip 538 B 538 B
link.html gzip 549 B 549 B
withRouter.html gzip 530 B 530 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js bugfix/correct-page-key Change
buildDuration 6.9s 7.1s ⚠️ +209ms
buildDurationCached 3s 3.1s ⚠️ +75ms
nodeModulesSize 196 MB 196 MB ⚠️ +305 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js bugfix/correct-page-key Change
/ failed reqs 0 0
/ total time (seconds) 3.43 3.704 ⚠️ +0.27
/ avg req/sec 728.76 674.87 ⚠️ -53.89
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.88 1.925 ⚠️ +0.05
/error-in-render avg req/sec 1330.01 1299.03 ⚠️ -30.98
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bugfix/correct-page-key Change
450.fd3ad245..022b.js gzip 179 B 179 B
675-f623fa2a..036a.js gzip 13.9 kB 13.9 kB
framework-13..70b0.js gzip 50.8 kB 50.8 kB
main-17a5f65..3805.js gzip 36.5 kB 36.5 kB
webpack-a7f2..2650.js gzip 1.63 kB 1.63 kB
Overall change 103 kB 103 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/correct-page-key Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js bugfix/correct-page-key Change
_app-ae91bc3..d985.js gzip 1.33 kB 1.33 kB
_error-273ac..9ef0.js gzip 180 B 180 B
amp-5f9a7694..99ce.js gzip 315 B 315 B
css-3a1b2477..df1e.js gzip 330 B 330 B
dynamic-e04a..a1b5.js gzip 2.79 kB 2.79 kB
head-7f600d0..daa3.js gzip 356 B 356 B
hooks-bd8c02..0730.js gzip 638 B 638 B
image-16df09..4584.js gzip 555 B 555 B
index-80be94..e89f.js gzip 262 B 262 B
link-4ee1ea7..8745.js gzip 2.22 kB 2.22 kB
routerDirect..c4aa.js gzip 325 B 325 B
script-67da0..49e6.js gzip 390 B 390 B
withRouter-2..2409.js gzip 322 B 322 B
9a34b27eb3f9..27d.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/correct-page-key Change
_buildManifest.js gzip 477 B 477 B
Overall change 477 B 477 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bugfix/correct-page-key Change
index.html gzip 534 B 534 B
link.html gzip 545 B 545 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 777a81a

@kodiakhq kodiakhq bot merged commit be2156f into canary Oct 21, 2021
@kodiakhq kodiakhq bot deleted the bugfix/correct-page-key branch October 21, 2021 10:52
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants