Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SWC OS and CPU fields #30341

Merged
merged 4 commits into from Oct 26, 2021
Merged

Update SWC OS and CPU fields #30341

merged 4 commits into from Oct 26, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 26, 2021

Fixes package.json fields for SWC packages.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Oct 26, 2021
@ijjk ijjk merged commit 4c83292 into vercel:canary Oct 26, 2021
@ijjk ijjk deleted the update/swc-pkg-fields branch October 26, 2021 18:11
@budchirp
Copy link

Why android tests run on macos?

@ijjk
Copy link
Member Author

ijjk commented Oct 26, 2021

We are following the template from napi-rs here which uses macos for building the android binary.

@ijjk
Copy link
Member Author

ijjk commented Oct 26, 2021

Note: this change is now available in v12.0.1-canary.2 of Next.js

@budchirp
Copy link

Note: this change is now available in v12.0.1-canary.2 of Next.js

Looks like that release don't published on npm because I can't install
Screenshot_20211026-225904_Chrome Canary

@ijjk
Copy link
Member Author

ijjk commented Oct 26, 2021

It might take a bit to propagate on npm, it's showing up for me

Screen Shot 2021-10-26 at 15 01 10

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@padmaia padmaia padmaia approved these changes

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ijjk @budchirp @styfle @padmaia