Make check release job parallel to build job #30350

ijjk · 2021-10-26T18:29:17Z

This tests moving the check-release step parallel to build as the git fetch step takes quite a while now.

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes by running yarn lint

ijjk · 2021-10-26T18:48:29Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	ijjk/next.js update/check-release-step	Change
buildDuration	17.1s	17.8s	⚠️ +637ms
buildDurationCached	3.6s	3.6s	-56ms
nodeModulesSize	207 MB	207 MB	-19 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js update/check-release-step	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.042	3.051	⚠️ +0.01
/ avg req/sec	821.7	819.36	⚠️ -2.34
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.466	1.427	-0.04
/error-in-render avg req/sec	1705.01	1751.88	+46.87

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js update/check-release-step	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	28 kB	28 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	71.9 kB	71.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js update/check-release-step	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js update/check-release-step	Change
_app-HASH.js gzip	1.23 kB	1.23 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	635 B	635 B	✓
image-HASH.js gzip	4.44 kB	4.44 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.87 kB	1.87 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
334f979574ae..6f4.css gzip	106 B	106 B	✓
Overall change	13.1 kB	13.1 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js update/check-release-step	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js update/check-release-step	Change
index.html gzip	532 B	532 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Default Build with SWC (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	ijjk/next.js update/check-release-step	Change
buildDuration	16.9s	15.2s	-1.7s
buildDurationCached	4s	3.8s	-217ms
nodeModulesSize	207 MB	207 MB	-19 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js update/check-release-step	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.347	3.003	-0.34
/ avg req/sec	746.89	832.58	+85.69
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.556	1.451	-0.1
/error-in-render avg req/sec	1606.87	1722.95	+116.08

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js update/check-release-step	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	28.2 kB	28.2 kB	✓
webpack-HASH.js gzip	1.43 kB	1.43 kB	✓
Overall change	72 kB	72 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js update/check-release-step	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js update/check-release-step	Change
_app-HASH.js gzip	1.22 kB	1.22 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	621 B	621 B	✓
image-HASH.js gzip	4.46 kB	4.46 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	1.9 kB	1.9 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
334f979574ae..6f4.css gzip	106 B	106 B	✓
Overall change	13.1 kB	13.1 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js update/check-release-step	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js update/check-release-step	Change
index.html gzip	534 B	534 B	✓
link.html gzip	547 B	547 B	✓
withRouter.html gzip	528 B	528 B	✓
Overall change	1.61 kB	1.61 kB	✓

Commit: e606f45

ijjk · 2021-10-26T19:03:16Z

Failing test suites

Commit: e606f45

test/development/acceptance/ReactRefreshRegression.test.ts

ReactRefreshRegression > styled-components hydration mismatch
ReactRefreshRegression > can fast refresh a page with getStaticProps
ReactRefreshRegression > can fast refresh a page with getServerSideProps
ReactRefreshRegression > can fast refresh a page with config
ReactRefreshRegression > shows an overlay for a server-side error
ReactRefreshRegression > custom loader (mdx) should have Fast Refresh enabled

Expand output

● ReactRefreshRegression › styled-components hydration mismatch

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

   7 |   let next: NextInstance
   8 |
>  9 |   beforeAll(async () => {
     |   ^
  10 |     next = await createNext({
  11 |       files: {},
  12 |       skipStart: true,

  at development/acceptance/ReactRefreshRegression.test.ts:9:3
  at Object.<anonymous> (development/acceptance/ReactRefreshRegression.test.ts:6:1)

● ReactRefreshRegression › can fast refresh a page with getStaticProps

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

   7 |   let next: NextInstance
   8 |
>  9 |   beforeAll(async () => {
     |   ^
  10 |     next = await createNext({
  11 |       files: {},
  12 |       skipStart: true,

  at development/acceptance/ReactRefreshRegression.test.ts:9:3
  at Object.<anonymous> (development/acceptance/ReactRefreshRegression.test.ts:6:1)

● ReactRefreshRegression › can fast refresh a page with getServerSideProps

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

   7 |   let next: NextInstance
   8 |
>  9 |   beforeAll(async () => {
     |   ^
  10 |     next = await createNext({
  11 |       files: {},
  12 |       skipStart: true,

  at development/acceptance/ReactRefreshRegression.test.ts:9:3
  at Object.<anonymous> (development/acceptance/ReactRefreshRegression.test.ts:6:1)

● ReactRefreshRegression › can fast refresh a page with config

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

   7 |   let next: NextInstance
   8 |
>  9 |   beforeAll(async () => {
     |   ^
  10 |     next = await createNext({
  11 |       files: {},
  12 |       skipStart: true,

  at development/acceptance/ReactRefreshRegression.test.ts:9:3
  at Object.<anonymous> (development/acceptance/ReactRefreshRegression.test.ts:6:1)

● ReactRefreshRegression › shows an overlay for a server-side error

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

   7 |   let next: NextInstance
   8 |
>  9 |   beforeAll(async () => {
     |   ^
  10 |     next = await createNext({
  11 |       files: {},
  12 |       skipStart: true,

  at development/acceptance/ReactRefreshRegression.test.ts:9:3
  at Object.<anonymous> (development/acceptance/ReactRefreshRegression.test.ts:6:1)

● ReactRefreshRegression › custom loader (mdx) should have Fast Refresh enabled

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

   7 |   let next: NextInstance
   8 |
>  9 |   beforeAll(async () => {
     |   ^
  10 |     next = await createNext({
  11 |       files: {},
  12 |       skipStart: true,

  at development/acceptance/ReactRefreshRegression.test.ts:9:3
  at Object.<anonymous> (development/acceptance/ReactRefreshRegression.test.ts:6:1)

● Test suite failed to run

TypeError: Cannot read property 'destroy' of undefined

  18 |     })
  19 |   })
> 20 |   afterAll(() => next.destroy())
     |                       ^
  21 |
  22 |   // https://github.com/vercel/next.js/issues/12422
  23 |   test('styled-components hydration mismatch', async () => {

  at development/acceptance/ReactRefreshRegression.test.ts:20:23

● Test suite failed to run

next instance not destroyed before exiting, make sure to call .destroy() after the tests after finished

  77 |     if (nextInstance) {
  78 |       await nextInstance.destroy()
> 79 |       throw new Error(
     |             ^
  80 |         `next instance not destroyed before exiting, make sure to call .destroy() after the tests after finished`
  81 |       )
  82 |     }

  at lib/e2e-utils.ts:79:13

test/integration/react-18/test/index.test.js

Concurrent mode > concurrentFeatures is enabled (dev) > should resolve suspense modules on server side if suspense
Concurrent mode > concurrentFeatures is enabled (dev) > should resolve suspense on server side if not suspended on server
Concurrent mode > concurrentFeatures is enabled (dev) > should resolve suspense on server side if suspended on server
Concurrent mode > concurrentFeatures is enabled (dev) > should hydrate suspenses on client side if suspended on server
Concurrent mode > concurrentFeatures is enabled (dev) > should drain the entire response
Concurrent mode > concurrentFeatures is enabled (dev) > should stream to users
Concurrent mode > concurrentFeatures is enabled (dev) > should not stream to bots
Concurrent mode > concurrentFeatures is enabled (prod) > should resolve suspense modules on server side if suspense
Concurrent mode > concurrentFeatures is enabled (prod) > should resolve suspense on server side if not suspended on server
Concurrent mode > concurrentFeatures is enabled (prod) > should resolve suspense on server side if suspended on server
Concurrent mode > concurrentFeatures is enabled (prod) > should hydrate suspenses on client side if suspended on server
Concurrent mode > concurrentFeatures is enabled (prod) > should drain the entire response
Concurrent mode > concurrentFeatures is enabled (prod) > should stream to users
Concurrent mode > concurrentFeatures is enabled (prod) > should not stream to bots

Expand output

● Concurrent mode › concurrentFeatures is enabled (dev) › should resolve suspense modules on server side if suspense

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:36891/suspense/no-preload", waiting until "load"
============================================================

  113 |       traceStarted = true
  114 |     }
> 115 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  116 |   }
  117 |
  118 |   back(): BrowserInterface {

  at Playwright.loadPage (lib/browsers/playwright.ts:115:16)
  at Object.webdriver [as default] (lib/next-webdriver.ts:83:3)
  at withBrowser (integration/react-18/test/concurrent.js:10:17)
  at Object.<anonymous> (integration/react-18/test/concurrent.js:20:5)

● Concurrent mode › concurrentFeatures is enabled (dev) › should resolve suspense on server side if not suspended on server

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:36891/suspense/no-thrown", waiting until "load"
============================================================

  113 |       traceStarted = true
  114 |     }
> 115 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  116 |   }
  117 |
  118 |   back(): BrowserInterface {

  at Playwright.loadPage (lib/browsers/playwright.ts:115:16)
  at Object.webdriver [as default] (lib/next-webdriver.ts:83:3)
  at withBrowser (integration/react-18/test/concurrent.js:10:17)
  at Object.<anonymous> (integration/react-18/test/concurrent.js:30:5)

● Concurrent mode › concurrentFeatures is enabled (dev) › should resolve suspense on server side if suspended on server

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:36891/suspense/thrown", waiting until "load"
============================================================

  113 |       traceStarted = true
  114 |     }
> 115 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  116 |   }
  117 |
  118 |   back(): BrowserInterface {

  at Playwright.loadPage (lib/browsers/playwright.ts:115:16)
  at Object.webdriver [as default] (lib/next-webdriver.ts:83:3)
  at withBrowser (integration/react-18/test/concurrent.js:10:17)
  at Object.<anonymous> (integration/react-18/test/concurrent.js:43:5)

● Concurrent mode › concurrentFeatures is enabled (dev) › should hydrate suspenses on client side if suspended on server

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:36891/suspense/thrown", waiting until "load"
============================================================

  113 |       traceStarted = true
  114 |     }
> 115 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  116 |   }
  117 |
  118 |   back(): BrowserInterface {

  at Playwright.loadPage (lib/browsers/playwright.ts:115:16)
  at Object.webdriver [as default] (lib/next-webdriver.ts:83:3)
  at withBrowser (integration/react-18/test/concurrent.js:10:17)
  at Object.<anonymous> (integration/react-18/test/concurrent.js:56:5)

● Concurrent mode › concurrentFeatures is enabled (dev) › should drain the entire response

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:36891/suspense/backpressure", waiting until "load"
============================================================

  113 |       traceStarted = true
  114 |     }
> 115 |     await page.goto(url, { waitUntil: 'load' })
      |                ^
  116 |   }
  117 |
  118 |   back(): BrowserInterface {

  at Playwright.loadPage (lib/browsers/playwright.ts:115:16)
  at Object.webdriver [as default] (lib/next-webdriver.ts:83:3)
  at withBrowser (integration/react-18/test/concurrent.js:10:17)
  at Object.<anonymous> (integration/react-18/test/concurrent.js:66:5)

● Concurrent mode › concurrentFeatures is enabled (dev) › should stream to users

thrown: "Exceeded timeout of 90000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  168 |     concurrent(context, (p, q) => renderViaHTTP(context.appPort, p, q))
  169 |
> 170 |     it('should stream to users', async () => {
      |     ^
  171 |       const res = await fetchViaHTTP(context.appPort, '/ssr')
  172 |       expect(res.headers.get('etag')).toBeNull()
  173 |     })

  at integration/react-18/test/index.test.js:170:5
  at integration/react-18/test/index.test.js:210:5
  at runTest (integration/react-18/test/index.test.js:193:3)
  at runTests (integration/react-18/test/index.test.js:215:3)
  at integration/react-18/test/index.test.js:167:3
  at Object.<anonymous> (integration/react-18/test/index.test.js:152:1)

● Concurrent mode › concurrentFeatures is enabled (dev) › should not stream to bots

thrown: "Exceeded timeout of 90000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  173 |     })
  174 |
> 175 |     it('should not stream to bots', async () => {
      |     ^
  176 |       const res = await fetchViaHTTP(
  177 |         context.appPort,
  178 |         '/ssr',

  at integration/react-18/test/index.test.js:175:5
  at integration/react-18/test/index.test.js:210:5
  at runTest (integration/react-18/test/index.test.js:193:3)
  at runTests (integration/react-18/test/index.test.js:215:3)
  at integration/react-18/test/index.test.js:167:3
  at Object.<anonymous> (integration/react-18/test/index.test.js:152:1)

● Concurrent mode › concurrentFeatures is enabled (prod) › should resolve suspense modules on server side if suspense

command failed with code 1

  174 |         code !== 0
  175 |       ) {
> 176 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  177 |       }
  178 |
  179 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:176:23)

● Concurrent mode › concurrentFeatures is enabled (prod) › should resolve suspense on server side if not suspended on server

command failed with code 1

  174 |         code !== 0
  175 |       ) {
> 176 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  177 |       }
  178 |
  179 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:176:23)

● Concurrent mode › concurrentFeatures is enabled (prod) › should resolve suspense on server side if suspended on server

command failed with code 1

  174 |         code !== 0
  175 |       ) {
> 176 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  177 |       }
  178 |
  179 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:176:23)

● Concurrent mode › concurrentFeatures is enabled (prod) › should hydrate suspenses on client side if suspended on server

command failed with code 1

  174 |         code !== 0
  175 |       ) {
> 176 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  177 |       }
  178 |
  179 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:176:23)

● Concurrent mode › concurrentFeatures is enabled (prod) › should drain the entire response

command failed with code 1

  174 |         code !== 0
  175 |       ) {
> 176 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  177 |       }
  178 |
  179 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:176:23)

● Concurrent mode › concurrentFeatures is enabled (prod) › should stream to users

command failed with code 1

  174 |         code !== 0
  175 |       ) {
> 176 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  177 |       }
  178 |
  179 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:176:23)

● Concurrent mode › concurrentFeatures is enabled (prod) › should not stream to bots

command failed with code 1

  174 |         code !== 0
  175 |       ) {
> 176 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  177 |       }
  178 |
  179 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:176:23)

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  329 | export async function killApp(instance) {
  330 |   await new Promise((resolve, reject) => {
> 331 |     treeKill(instance.pid, (err) => {
      |                       ^
  332 |       if (err) {
  333 |         if (
  334 |           process.platform === 'win32' &&

  at lib/next-test-utils.js:331:23
  at Object.killApp (lib/next-test-utils.js:330:9)
  at integration/react-18/test/index.test.js:15:25

This reverts commit 8d82d76.

Make check release job parallel to build job

e606f45

ijjk added the created-by: Next.js team PRs by the Next.js team label Oct 26, 2021

ijjk requested review from padmaia and sokra October 26, 2021 18:29

sokra approved these changes Oct 26, 2021

View reviewed changes

sokra marked this pull request as ready for review October 26, 2021 21:04

sokra requested review from huozhi, shuding, styfle and timneutkens as code owners October 26, 2021 21:04

sokra merged commit 8d82d76 into vercel:canary Oct 26, 2021

ijjk deleted the update/check-release-step branch October 27, 2021 00:37

ijjk added a commit that referenced this pull request Oct 27, 2021

Revert "Make check release job parallel to build job (#30350)"

a92a8f9

This reverts commit 8d82d76.

ijjk mentioned this pull request Oct 27, 2021

Revert "Make check release job parallel to build job" #30388

Merged

ijjk added a commit that referenced this pull request Oct 27, 2021

Revert "Make check release job parallel to build job (#30350)" (#30388)

8a445ca

This reverts commit 8d82d76.

styfle added the hacktoberfest-accepted label Oct 31, 2021

ijjk mentioned this pull request Dec 9, 2021

Update only fetch all tags for publish commits #32337

Merged

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make check release job parallel to build job #30350

Make check release job parallel to build job #30350

ijjk commented Oct 26, 2021

ijjk commented Oct 26, 2021

ijjk commented Oct 26, 2021 •

edited

Make check release job parallel to build job #30350

Make check release job parallel to build job #30350

Conversation

ijjk commented Oct 26, 2021

Bug

Feature

Documentation / Examples

ijjk commented Oct 26, 2021

Stats from current PR

ijjk commented Oct 26, 2021 • edited

Failing test suites

ijjk commented Oct 26, 2021 •

edited