Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add incremental to template/tsconfig.json to avoid changes on first build #30357

Merged
merged 6 commits into from Oct 27, 2021

Conversation

oBusk
Copy link
Contributor

@oBusk oBusk commented Oct 26, 2021

I used create-next-app to create a new fancy Next 12 app, ran yarn build and got a git diff. The tsconfig.json had a incremental added by next. Just running build shouldn't need I have uncommitted changes.

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Oct 26, 2021
Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The incremental: true is a good find

packages/create-next-app/create-app.ts Show resolved Hide resolved
@akadop
Copy link

akadop commented Oct 26, 2021

Build fails when incremental is missing from an extended tsconfig

does not whether or not incremental=true or incremental=false, if incremental is in the extended config than it works correctly

#30360

https://github.com/akadop/next-v12-monorepo-bug

@oBusk
Copy link
Contributor Author

oBusk commented Oct 26, 2021

Would something very primitive like this be good to have? oBusk@27b8b29

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Oct 27, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary oBusk/next.js stable-tsconfig-json Change
buildDuration 23.7s 23.5s -244ms
buildDurationCached 4.7s 4.6s -64ms
nodeModulesSize 207 MB 207 MB ⚠️ +3 B
Page Load Tests Overall increase ✓
vercel/next.js canary oBusk/next.js stable-tsconfig-json Change
/ failed reqs 0 0
/ total time (seconds) 4.258 4.17 -0.09
/ avg req/sec 587.1 599.49 +12.39
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.197 2.114 -0.08
/error-in-render avg req/sec 1137.72 1182.81 +45.09
Client Bundles (main, webpack, commons)
vercel/next.js canary oBusk/next.js stable-tsconfig-json Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary oBusk/next.js stable-tsconfig-json Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary oBusk/next.js stable-tsconfig-json Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary oBusk/next.js stable-tsconfig-json Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary oBusk/next.js stable-tsconfig-json Change
index.html gzip 535 B 535 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary oBusk/next.js stable-tsconfig-json Change
buildDuration 20.4s 20s -391ms
buildDurationCached 4.7s 4.8s ⚠️ +63ms
nodeModulesSize 207 MB 207 MB ⚠️ +3 B
Page Load Tests Overall increase ✓
vercel/next.js canary oBusk/next.js stable-tsconfig-json Change
/ failed reqs 0 0
/ total time (seconds) 4.087 4.069 -0.02
/ avg req/sec 611.75 614.36 +2.61
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.129 2.067 -0.06
/error-in-render avg req/sec 1174.25 1209.2 +34.95
Client Bundles (main, webpack, commons)
vercel/next.js canary oBusk/next.js stable-tsconfig-json Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72 kB 72 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary oBusk/next.js stable-tsconfig-json Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary oBusk/next.js stable-tsconfig-json Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 621 B 621 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary oBusk/next.js stable-tsconfig-json Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary oBusk/next.js stable-tsconfig-json Change
index.html gzip 535 B 535 B
link.html gzip 547 B 547 B
withRouter.html gzip 529 B 529 B
Overall change 1.61 kB 1.61 kB
Commit: 77de9ef

@kodiakhq kodiakhq bot merged commit 718003c into vercel:canary Oct 27, 2021
@oBusk oBusk deleted the stable-tsconfig-json branch October 27, 2021 11:53
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants