Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore incremental TS compilation build info #30362

Merged
merged 1 commit into from Oct 26, 2021
Merged

Conversation

kripod
Copy link
Contributor

@kripod kripod commented Oct 26, 2021

Adds *.tsbuildinfo to the gitignore file of the official TypeScript starter, as incremental TypeScript builds are suggested since Next.js 12.

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Oct 26, 2021
@ijjk
Copy link
Member

ijjk commented Oct 26, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary kripod/next.js patch-2 Change
buildDuration 20.2s 20.9s ⚠️ +739ms
buildDurationCached 4.4s 4.2s -190ms
nodeModulesSize 207 MB 207 MB
Page Load Tests Overall increase ✓
vercel/next.js canary kripod/next.js patch-2 Change
/ failed reqs 0 0
/ total time (seconds) 3.422 3.422
/ avg req/sec 730.57 730.55 ⚠️ -0.02
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.64 1.63 -0.01
/error-in-render avg req/sec 1524.72 1533.96 +9.24
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js patch-2 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kripod/next.js patch-2 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kripod/next.js patch-2 Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary kripod/next.js patch-2 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kripod/next.js patch-2 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary kripod/next.js patch-2 Change
buildDuration 17.6s 17.3s -340ms
buildDurationCached 4.3s 4.3s ⚠️ +38ms
nodeModulesSize 207 MB 207 MB
Page Load Tests Overall increase ✓
vercel/next.js canary kripod/next.js patch-2 Change
/ failed reqs 0 0
/ total time (seconds) 3.415 3.385 -0.03
/ avg req/sec 732.04 738.53 +6.49
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.619 1.565 -0.05
/error-in-render avg req/sec 1544.03 1597.13 +53.1
Client Bundles (main, webpack, commons)
vercel/next.js canary kripod/next.js patch-2 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72 kB 72 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kripod/next.js patch-2 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kripod/next.js patch-2 Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 621 B 621 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary kripod/next.js patch-2 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kripod/next.js patch-2 Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: fcce0c7

@ijjk
Copy link
Member

ijjk commented Oct 26, 2021

Failing test suites

Commit: fcce0c7

test/integration/preload-viewport/test/index.test.js

  • Prefetching Links in viewport > should not prefetch already loaded scripts
Expand output

● Prefetching Links in viewport › should not prefetch already loaded scripts

expect(received).toBe(expected) // Object.is equality

Expected: false
Received: true

  397 |     expect(hrefs).toEqual([...new Set(hrefs)])
  398 |
> 399 |     // Verify encoding
      |     ^
  400 |     expect(hrefs.some((e) => e.includes(`%5Bhello%5D-`))).toBe(true)
  401 |   })
  402 |

  at Object.<anonymous> (integration/preload-viewport/test/index.test.js:399:5)

@sokra sokra merged commit bc0b50d into vercel:canary Oct 26, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants