Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to copy necessary RSC files from dep #30505

Merged
merged 4 commits into from Oct 28, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 28, 2021

This updates to copy the necessary files from the react-server-dom-webpack dependency to prevent installing un-used dependencies.

Closes: #30479

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Oct 28, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review October 28, 2021 04:56
@ijjk
Copy link
Member Author

ijjk commented Oct 28, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/copy-rsc-dep Change
buildDuration 21.5s 21.8s ⚠️ +351ms
buildDurationCached 4.3s 4.6s ⚠️ +290ms
nodeModulesSize 207 MB 198 MB -8.6 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/copy-rsc-dep Change
/ failed reqs 0 0
/ total time (seconds) 3.901 3.895 -0.01
/ avg req/sec 640.93 641.86 +0.93
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.054 2.049 0
/error-in-render avg req/sec 1217.07 1220.15 +3.08
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/copy-rsc-dep Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/copy-rsc-dep Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/copy-rsc-dep Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/copy-rsc-dep Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/copy-rsc-dep Change
index.html gzip 534 B 534 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/copy-rsc-dep Change
buildDuration 18.8s 18.4s -368ms
buildDurationCached 4.4s 4.4s -76ms
nodeModulesSize 207 MB 198 MB -8.6 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/copy-rsc-dep Change
/ failed reqs 0 0
/ total time (seconds) 3.866 3.907 ⚠️ +0.04
/ avg req/sec 646.63 639.83 ⚠️ -6.8
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.994 2.085 ⚠️ +0.09
/error-in-render avg req/sec 1253.92 1199.25 ⚠️ -54.67
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/copy-rsc-dep Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/copy-rsc-dep Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/copy-rsc-dep Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/copy-rsc-dep Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/copy-rsc-dep Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: e21e40a

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants