Add security notes to the URL imports documentation. #30708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leerob
requested review from
huozhi,
ijjk,
lfades,
molebox,
padmaia,
shuding,
styfle and
timneutkens
as code owners
styfle
reviewed
Oct 31, 2021
styfle
reviewed
Oct 31, 2021
leerob
commented
Oct 31, 2021
timneutkens
approved these changes
Nov 1, 2021
timneutkens
reviewed
Nov 1, 2021
| @@ -27,6 +27,10 @@ import { a, b, c } from 'https://example.com/modules/some/module.js' | |||
|
|
|||
| URL Imports can be used everywhere normal package imports can be used. | |||
|
|
|||
| ## Security Model | |||
|
|
|||
| This feature is being designed with **security as the top priority**. To start, we added an experimental flag forcing you to explicitly allow the domains you accept URL imports from. We're working to take this further by limiting URL imports to execute in the browser sandbox using the [Edge Runtime](/docs/api-reference/edge-runtime.md). This runtime is used by [Middleware](/docs/middleware.md) as well as [Next.js Live](https://vercel.com/live). | |||
There was a problem hiding this comment.
This looks fine, I think it should also explain how files are downloaded and locked during development and not downloaded at runtime. Can be done in a follow-up PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.