Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure dev binary download skips for docs only change #30746

Merged
merged 1 commit into from Nov 1, 2021
Merged

Ensure dev binary download skips for docs only change #30746

merged 1 commit into from Nov 1, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 1, 2021

x-ref: https://github.com/vercel/next.js/runs/4063160089?check_suite_focus=true

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Nov 1, 2021
@ijjk ijjk merged commit ea91b9d into vercel:canary Nov 1, 2021
@ijjk ijjk deleted the update/download-dev-binary branch November 1, 2021 16:20
@ijjk ijjk mentioned this pull request Nov 1, 2021
Merged
timneutkens pushed a commit to timneutkens/next.js that referenced this pull request Nov 2, 2021
@ijjk @timneutkens
Ensure dev binary download skips for docs only change (vercel#30746)
d74cb5c
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@timneutkens timneutkens timneutkens approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ijjk @styfle @timneutkens