Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client component imports are not being correctly tracked #30853

Merged
merged 4 commits into from Nov 3, 2021

Conversation

shuding
Copy link
Member

@shuding shuding commented Nov 2, 2021

When there're multi-level server component imports, some components are eliminated after going through the client compilation, because we are only tracking .client. dependencies inside .server. components. Instead we should keep all imports for the client compilation, but only remove the content of server components.

This fixes vercel/next-react-server-components#7.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@shuding shuding changed the title Fix client components are not being correctly tracked Fix client component imports are not being correctly tracked Nov 2, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 3, 2021

Failing test suites

Commit: 19f0176

test/development/basic/hmr.test.ts

  • basic HMR > Hot Module Reloading > editing a page > should update styles correctly
Expand output

● basic HMR › Hot Module Reloading › editing a page › should update styles correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for selector ".hmr-style-page p"
============================================================

  250 |     return this.chain(() => {
  251 |       return page
> 252 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  253 |         .then(async (el) => {
  254 |           // it seems selenium waits longer and tests rely on this behavior
  255 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:252:10

@ijjk
Copy link
Member

ijjk commented Nov 3, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/04e1 Change
buildDuration 19.8s 20.2s ⚠️ +323ms
buildDurationCached 4.3s 4.3s ⚠️ +76ms
nodeModulesSize 293 MB 293 MB ⚠️ +227 B
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/04e1 Change
/ failed reqs 0 0
/ total time (seconds) 3.514 3.768 ⚠️ +0.25
/ avg req/sec 711.49 663.47 ⚠️ -48.02
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.047 1.849 -0.2
/error-in-render avg req/sec 1221.46 1352.26 +130.8
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/04e1 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/04e1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/04e1 Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/04e1 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/04e1 Change
index.html gzip 521 B 521 B
link.html gzip 533 B 533 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/04e1 Change
buildDuration 21.8s 21.6s -216ms
buildDurationCached 4.2s 4.3s ⚠️ +56ms
nodeModulesSize 293 MB 293 MB ⚠️ +227 B
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/04e1 Change
/ failed reqs 0 0
/ total time (seconds) 3.343 3.495 ⚠️ +0.15
/ avg req/sec 747.8 715.27 ⚠️ -32.53
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.903 1.835 -0.07
/error-in-render avg req/sec 1313.95 1362.76 +48.81
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/04e1 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/04e1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/04e1 Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/04e1 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/04e1 Change
index.html gzip 521 B 521 B
link.html gzip 534 B 534 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB
Commit: 19f0176

@ijjk ijjk merged commit 0fa233b into vercel:canary Nov 3, 2021
@shuding shuding deleted the shu/04e1 branch November 3, 2021 02:55
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-page server component cannot import client component
2 participants