Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct tmpdir is used for install-native #30855

Merged
merged 3 commits into from Nov 3, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 3, 2021

Uses path.join to fix:

[Error: EACCES: permission denied, mkdir '/tmpnext-swc-1635896565674'] {
  errno: -13,
  code: 'EACCES',
  syscall: 'mkdir',
  path: '/tmpnext-swc-1635896565674'
}

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Nov 3, 2021
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Nov 3, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js fix/native-tmpdir Change
buildDuration 17.9s 18.1s ⚠️ +232ms
buildDurationCached 3.8s 3.7s -78ms
nodeModulesSize 293 MB 293 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/native-tmpdir Change
/ failed reqs 0 0
/ total time (seconds) 2.877 2.805 -0.07
/ avg req/sec 869.05 891.32 +22.27
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.351 1.315 -0.04
/error-in-render avg req/sec 1850.69 1901.77 +51.08
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/native-tmpdir Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/native-tmpdir Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/native-tmpdir Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/native-tmpdir Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/native-tmpdir Change
index.html gzip 521 B 521 B
link.html gzip 533 B 533 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js fix/native-tmpdir Change
buildDuration 19.4s 19.4s ⚠️ +47ms
buildDurationCached 3.8s 3.8s ⚠️ +2ms
nodeModulesSize 293 MB 293 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/native-tmpdir Change
/ failed reqs 0 0
/ total time (seconds) 2.89 2.889 0
/ avg req/sec 865 865.46 +0.46
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.316 1.301 -0.02
/error-in-render avg req/sec 1899.71 1922.02 +22.31
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/native-tmpdir Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/native-tmpdir Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/native-tmpdir Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/native-tmpdir Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/native-tmpdir Change
index.html gzip 521 B 521 B
link.html gzip 534 B 534 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB
Commit: 1d42525

@ijjk ijjk marked this pull request as ready for review November 3, 2021 01:30
@ijjk ijjk merged commit 3aff5d4 into vercel:canary Nov 3, 2021
@ijjk ijjk deleted the fix/native-tmpdir branch November 3, 2021 01:30
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant