Docs/examples/with iron session updates #30956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvo
requested review from
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
leerob
reviewed
Nov 6, 2021
1 task
vvo
force-pushed
the
docs/examples/with-iron-session-updates
branch
from
e8f7ec1
to
11b7b79
Compare
This commit updates the with-iron-session example to follow the new API of iron-session and also rewrites it in TypeScript.
vvo
force-pushed
the
docs/examples/with-iron-session-updates
branch
from
11b7b79
to
0f26e6f
Compare
leerob
reviewed
Nov 8, 2021
leerob
previously approved these changes
Nov 8, 2021
|
@leerob thanks for making the changes. If there's something else I can do let me know. |
leerob
approved these changes
Nov 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, I've just published a completely new version of iron-session. I took the opportunity to 1. update the current example with the new API and 2. provide a full TypeScript example which was a common question of users of the library.
Let me know if you have any questions. Thanks a lot.
Documentation / Examples
yarn lint