Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resolving for node_modules trace pass #30985

Merged
merged 2 commits into from Nov 5, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 4, 2021

This updates the node_modules output file tracing pass to use the nft resolver as it is able to gather all package.json's correctly while we aren't able to do that while using the webpack resolver currently as noted here. This also seems to provide slightly better performance on larger apps.

Test deployment for react-icons case here

Fixes: #30486

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Nov 4, 2021
@ijjk ijjk marked this pull request as ready for review November 4, 2021 21:20
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Nov 4, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/nodemodules-trace-resolve Change
buildDuration 17.9s 17.8s -142ms
buildDurationCached 3.7s 3.6s -79ms
nodeModulesSize 332 MB 332 MB -377 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/nodemodules-trace-resolve Change
/ failed reqs 0 0
/ total time (seconds) 2.926 2.871 -0.06
/ avg req/sec 854.38 870.77 +16.39
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.315 1.308 -0.01
/error-in-render avg req/sec 1900.83 1911.82 +10.99
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/nodemodules-trace-resolve Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/nodemodules-trace-resolve Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/nodemodules-trace-resolve Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/nodemodules-trace-resolve Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/nodemodules-trace-resolve Change
index.html gzip 523 B 523 B
link.html gzip 535 B 535 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/nodemodules-trace-resolve Change
buildDuration 19.6s 19.4s -202ms
buildDurationCached 3.6s 3.7s ⚠️ +98ms
nodeModulesSize 332 MB 332 MB -377 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/nodemodules-trace-resolve Change
/ failed reqs 0 0
/ total time (seconds) 2.857 2.97 ⚠️ +0.11
/ avg req/sec 874.99 841.73 ⚠️ -33.26
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.366 1.46 ⚠️ +0.09
/error-in-render avg req/sec 1829.7 1712.64 ⚠️ -117.06
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/nodemodules-trace-resolve Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/nodemodules-trace-resolve Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/nodemodules-trace-resolve Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/nodemodules-trace-resolve Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/nodemodules-trace-resolve Change
index.html gzip 522 B 522 B
link.html gzip 535 B 535 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB
Commit: 8faad06

@ijjk ijjk merged commit bf097f1 into vercel:canary Nov 5, 2021
@ijjk ijjk deleted the update/nodemodules-trace-resolve branch November 5, 2021 01:09
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next.js 12 failing with react-icons
2 participants