Remove unused "start" script from with-docker/package.json #31053
Conversation
stefee
requested review from
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
| The `start` script in `package.json` has been modified to accept a `PORT` environment variable (for compatibility with Google Cloud Run). | ||
|
|
There was a problem hiding this comment.
I believe it is not necessary to change the usage of next start since it will pick up $PORT value anyway (the -p flag is redundant if $PORT variable is present)
There was a problem hiding this comment.
This is explicitly needed for deployment to Google Cloud. Maybe we can add a comment?
There was a problem hiding this comment.
So I understand correctly - which part is needed for GC, the start script in package.json, or the -p parameter on next CLI, or both?
We don't pass the -p parameter in Dockerfile CMD since 5abfea3.
Happy to close this PR if not needed!
| @@ -2,8 +2,7 @@ | |||
| "private": true, | |||
| "scripts": { | |||
| "dev": "next dev", | |||
| "build": "next build", | |||
| "start": "next start -p ${PORT:=3000}" | |||
There was a problem hiding this comment.
Removed unused script for clarity - the Dockerfile contains the entrypoint in this example
Fixes #29023 ## Bug - [x] Related issues linked using `fixes #number` - [ ] Integration tests added - [x] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [x] Make sure the linting passes
There was a problem hiding this comment.
This looks good as we are now using the standalone server from outputStandalone, thanks for the PR!
Fixes 5abfea3#r59373484 CC @Duncan-Brain, @leerob
See also:
with-dockerexample and deployment docs. #23486Documentation / Examples
yarn lint