Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates with-supertokens example to add sign in with apple #31200

Merged
merged 89 commits into from Nov 13, 2021
Merged

Updates with-supertokens example to add sign in with apple #31200

merged 89 commits into from Nov 13, 2021

Conversation

rishabhpoddar
Copy link
Contributor

@rishabhpoddar rishabhpoddar commented Nov 9, 2021

  • Adds sign in with apple
  • Updates node SDK dependency version
  • Extracted OAuth keys to a .env file.

NkxxkN and others added 30 commits February 16, 2021 15:21
Co-authored-by: Lee Robinson <me@leerob.io>
Co-authored-by: Lee Robinson <me@leerob.io>
Co-authored-by: Lee Robinson <me@leerob.io>
@ijjk ijjk added the examples Issue/PR related to examples label Nov 9, 2021
@leerob
Copy link
Member

leerob commented Nov 9, 2021

Could you make sure the PR doesn't include unrelated commits in the future? 🙏

@rishabhpoddar
Copy link
Contributor Author

Could you make sure the PR doesn't include unrelated commits in the future? 🙏

Are you referring to the wall of commits that are shown in this PR? Cause I don't intend for them to be there. I simply create a PR from our fork to yours. I'm not sure why they show up. Am I doing something wrong?

@rishabhpoddar
Copy link
Contributor Author

rishabhpoddar commented Nov 9, 2021

@leerob I have moved the keys to a .env file.

@jscyo
Copy link
Contributor

jscyo commented Nov 11, 2021

Hey, since it's my first time contributing it seems like we need an additional reviewer to approve the PR

@rishabhpoddar
Copy link
Contributor Author

@leerob could you approve running the workflows please? Thank you.

@leerob leerob merged commit f6c62d3 into vercel:canary Nov 13, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants