Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip flaky dynamic import tests #31221

Merged
merged 3 commits into from Nov 9, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Nov 9, 2021

No description provided.

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Nov 9, 2021
sokra
sokra previously approved these changes Nov 9, 2021
@ijjk
Copy link
Member

ijjk commented Nov 9, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js test/skip-lazy-temp Change
buildDuration 23.9s 23.5s -398ms
buildDurationCached 4.8s 4.8s ⚠️ +19ms
nodeModulesSize 333 MB 333 MB -6 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js test/skip-lazy-temp Change
/ failed reqs 0 0
/ total time (seconds) 4.005 3.993 -0.01
/ avg req/sec 624.25 626.03 +1.78
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.336 2.231 -0.1
/error-in-render avg req/sec 1070.41 1120.57 +50.16
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js test/skip-lazy-temp Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.1 kB 28.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js test/skip-lazy-temp Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js test/skip-lazy-temp Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js test/skip-lazy-temp Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js test/skip-lazy-temp Change
index.html gzip 524 B 524 B
link.html gzip 535 B 535 B
withRouter.html gzip 518 B 518 B
Overall change 1.58 kB 1.58 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js test/skip-lazy-temp Change
buildDuration 25.2s 26.7s ⚠️ +1.5s
buildDurationCached 4.7s 4.8s ⚠️ +37ms
nodeModulesSize 333 MB 333 MB -6 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js test/skip-lazy-temp Change
/ failed reqs 0 0
/ total time (seconds) 4.027 4.147 ⚠️ +0.12
/ avg req/sec 620.77 602.78 ⚠️ -17.99
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.055 2.263 ⚠️ +0.21
/error-in-render avg req/sec 1216.75 1104.88 ⚠️ -111.87
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js test/skip-lazy-temp Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js test/skip-lazy-temp Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js test/skip-lazy-temp Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js test/skip-lazy-temp Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js test/skip-lazy-temp Change
index.html gzip 523 B 523 B
link.html gzip 536 B 536 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB
Commit: ca2795b

@kodiakhq kodiakhq bot merged commit 489ca73 into vercel:canary Nov 9, 2021
@huozhi huozhi mentioned this pull request Nov 11, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
@huozhi huozhi deleted the test/skip-lazy-temp branch February 3, 2022 15:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants