Ensure NODE_ENV is replaced correctly with swc

[ijjk]

This ensures we replace NODE_ENV while transpiling with swc the same way we do when transpiling with babel (related config) which ensures webpack doesn't attempt including modules that should be dead-code eliminated.

Bug

• Related issues linked using fixes #number
• Integration tests added
• Errors have helpful link attached, see contributing.md

x-ref: #30705

[ijjk]

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js fix/node-env-replacing	Change
buildDuration	20.6s	21.5s	⚠️ +975ms
buildDurationCached	4.1s	4.1s	⚠️ +12ms
nodeModulesSize	335 MB	335 MB	⚠️ +224 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js fix/node-env-replacing	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.364	3.409	⚠️ +0.04
/ avg req/sec	743.1	733.37	⚠️ -9.73
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.567	1.644	⚠️ +0.08
/error-in-render avg req/sec	1594.91	1520.78	⚠️ -74.13

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js fix/node-env-replacing	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	28.3 kB	28.3 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.2 kB	72.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/node-env-replacing	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/node-env-replacing	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	635 B	635 B	✓
image-HASH.js gzip	4.44 kB	4.44 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.87 kB	1.87 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	13.3 kB	13.3 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/node-env-replacing	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js fix/node-env-replacing	Change
index.html gzip	522 B	522 B	✓
link.html gzip	535 B	535 B	✓
withRouter.html gzip	515 B	515 B	✓
Overall change	1.57 kB	1.57 kB	✓

Diffs

Diff for index.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-88c1bc1a66ea121e.js"
+      src="/_next/static/chunks/main-402d45a50f422db0.js"
       defer=""
     ></script>
     <script

Diff for link.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-88c1bc1a66ea121e.js"
+      src="/_next/static/chunks/main-402d45a50f422db0.js"
       defer=""
     ></script>
     <script

Diff for withRouter.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-88c1bc1a66ea121e.js"
+      src="/_next/static/chunks/main-402d45a50f422db0.js"
       defer=""
     ></script>
     <script

---

Default Build with SWC (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js fix/node-env-replacing	Change
buildDuration	22.1s	22s	-105ms
buildDurationCached	4.2s	4.1s	-12ms
nodeModulesSize	335 MB	335 MB	⚠️ +224 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js fix/node-env-replacing	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.405	3.335	-0.07
/ avg req/sec	734.21	749.68	+15.47
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.565	1.685	⚠️ +0.12
/error-in-render avg req/sec	1597.65	1483.33	⚠️ -114.32

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js fix/node-env-replacing	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	28.5 kB	28.5 kB	✓
webpack-HASH.js gzip	1.43 kB	1.43 kB	✓
Overall change	72.5 kB	72.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/node-env-replacing	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/node-env-replacing	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	622 B	622 B	✓
image-HASH.js gzip	4.46 kB	4.46 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	1.91 kB	1.91 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	13.2 kB	13.2 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/node-env-replacing	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js fix/node-env-replacing	Change
index.html gzip	522 B	522 B	✓
link.html gzip	534 B	534 B	✓
withRouter.html gzip	516 B	516 B	✓
Overall change	1.57 kB	1.57 kB	✓

Diffs

Diff for index.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-88c1bc1a66ea121e.js"
+      src="/_next/static/chunks/main-402d45a50f422db0.js"
       defer=""
     ></script>
     <script

Diff for link.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-88c1bc1a66ea121e.js"
+      src="/_next/static/chunks/main-402d45a50f422db0.js"
       defer=""
     ></script>
     <script

Diff for withRouter.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-88c1bc1a66ea121e.js"
+      src="/_next/static/chunks/main-402d45a50f422db0.js"
       defer=""
     ></script>
     <script

Commit: bf2b674