Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure asPath is correctly normalized in minimalMode with i18n #31281

Merged
merged 2 commits into from Nov 11, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 11, 2021

This ensures the asPath and req.url values are normalized correctly for fallback pages with i18n in minimal mode. This also copies the minimal mode test suite to run against i18n as well. This also fixes an issue where rewrite params weren't passed correctly on the client when no params were already used in the destination.

The provided reproduction has been deployed against this patch here show it working.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes: #27563
Fixes: #30203

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Nov 11, 2021
@ijjk ijjk marked this pull request as ready for review November 11, 2021 02:08
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Nov 11, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-blocking-asPath Change
buildDuration 23.8s 23.9s ⚠️ +95ms
buildDurationCached 4.7s 4.6s -90ms
nodeModulesSize 335 MB 335 MB ⚠️ +706 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/i18n-blocking-asPath Change
/ failed reqs 0 0
/ total time (seconds) 3.995 3.988 -0.01
/ avg req/sec 625.75 626.84 +1.09
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.136 2.096 -0.04
/error-in-render avg req/sec 1170.56 1192.8 +22.24
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-blocking-asPath Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-blocking-asPath Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-blocking-asPath Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-blocking-asPath Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/i18n-blocking-asPath Change
index.html gzip 522 B 522 B
link.html gzip 535 B 535 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-blocking-asPath Change
buildDuration 25.1s 25.2s ⚠️ +87ms
buildDurationCached 4.5s 4.6s ⚠️ +44ms
nodeModulesSize 335 MB 335 MB ⚠️ +706 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/i18n-blocking-asPath Change
/ failed reqs 0 0
/ total time (seconds) 4.251 4.077 -0.17
/ avg req/sec 588.03 613.24 +25.21
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.146 2.177 ⚠️ +0.03
/error-in-render avg req/sec 1164.76 1148.25 ⚠️ -16.51
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-blocking-asPath Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-blocking-asPath Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-blocking-asPath Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-blocking-asPath Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/i18n-blocking-asPath Change
index.html gzip 523 B 523 B
link.html gzip 535 B 535 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB
Commit: 7948e0e

@kodiakhq kodiakhq bot merged commit 6b89fbf into vercel:canary Nov 11, 2021
@ijjk ijjk deleted the fix/i18n-blocking-asPath branch November 11, 2021 20:19
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants