Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test-pnp stalling in CI #31282

Merged
merged 1 commit into from Nov 11, 2021
Merged

Fix test-pnp stalling in CI #31282

merged 1 commit into from Nov 11, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 11, 2021

This fixes the test-pnp test job stalling in CI lately.

x-ref: https://github.com/vercel/next.js/runs/4172582182?check_suite_focus=true
x-ref: https://github.com/vercel/next.js/runs/4173108617?check_suite_focus=true

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Nov 11, 2021
@ijjk ijjk marked this pull request as ready for review November 11, 2021 02:14
@ijjk
Copy link
Member Author

ijjk commented Nov 11, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/test-pnp Change
buildDuration 21.6s 21.9s ⚠️ +329ms
buildDurationCached 4.2s 4.2s -10ms
nodeModulesSize 334 MB 334 MB -10 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/test-pnp Change
/ failed reqs 0 0
/ total time (seconds) 3.818 3.734 -0.08
/ avg req/sec 654.86 669.54 +14.68
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.054 2.066 ⚠️ +0.01
/error-in-render avg req/sec 1217.43 1209.88 ⚠️ -7.55
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/test-pnp Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/test-pnp Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/test-pnp Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/test-pnp Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/test-pnp Change
index.html gzip 523 B 523 B
link.html gzip 535 B 535 B
withRouter.html gzip 517 B 517 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/test-pnp Change
buildDuration 23.4s 23.9s ⚠️ +501ms
buildDurationCached 4.2s 4.2s ⚠️ +18ms
nodeModulesSize 334 MB 334 MB -10 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/test-pnp Change
/ failed reqs 0 0
/ total time (seconds) 3.892 4.068 ⚠️ +0.18
/ avg req/sec 642.27 614.54 ⚠️ -27.73
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.054 2.092 ⚠️ +0.04
/error-in-render avg req/sec 1217.17 1195.26 ⚠️ -21.91
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/test-pnp Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/test-pnp Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/test-pnp Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/test-pnp Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/test-pnp Change
index.html gzip 522 B 522 B
link.html gzip 534 B 534 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB
Commit: a3869ad

@timneutkens timneutkens merged commit 35fb466 into vercel:canary Nov 11, 2021
@timneutkens timneutkens deleted the update/test-pnp branch November 11, 2021 10:56
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants