Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth0 API Call Incorrect in Example #31286

Closed
stevejarvis opened this issue Nov 11, 2021 · 1 comment · Fixed by #31284
Closed

Auth0 API Call Incorrect in Example #31286

stevejarvis opened this issue Nov 11, 2021 · 1 comment · Fixed by #31284
Labels
bug Issue was opened via the bug report template.

Comments

@stevejarvis
Copy link
Contributor

stevejarvis commented Nov 11, 2021 •
edited

What version of Next.js are you using?

canary

What version of Node.js are you using?

15.10.0

What browser are you using?

Firefox

What operating system are you using?

macOS

How are you deploying your application?

npm run dev

Describe the Bug

API signature mismatch between the example code and the Auth0 library. Required parameter (res) missing. Fix opened in #31284.

Expected Behavior

Profile page should load!

To Reproduce

Run the Auth0 example without the fix in PR #31284 and navigate to the server-rendered profile.
@stevejarvis stevejarvis added the bug Issue was opened via the bug report template. label Nov 11, 2021
@stevejarvis stevejarvis mentioned this issue Nov 11, 2021
Merged
3 tasks
@kodiakhq kodiakhq bot closed this as completed in #31284 Nov 11, 2021
kodiakhq bot pushed a commit that referenced this issue Nov 11, 2021
@stevejarvis
Fix Auth0 Example (#31284)
5014362 
Fixes #31286

I was going through the [Auth0 example](https://github.com/vercel/next.js/tree/canary/examples/auth0) and hit the following issue (screencap):

<img width="964" alt="Screen Shot 2021-11-10 at 12 57 41 PM" src="https://user-images.githubusercontent.com/2515575/141226775-08e5e1d3-618c-4fae-a133-70685c7b3ad2.png">

This just updates the call there to pass `res`, which matches the signature documented here: https://auth0.github.io/nextjs-auth0/modules/session_get_session.html

With this fix, the rest of the example worked wonderfully 👍.

## Bug

- [x] Related issues linked using `fixes #number`
- [ ] Integration tests added (NA?)
- [x] Errors have helpful link attached, see `contributing.md`
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
@stevejarvis @natew
Fix Auth0 Example (vercel#31284)
165a8b7 
Fixes vercel#31286

I was going through the [Auth0 example](https://github.com/vercel/next.js/tree/canary/examples/auth0) and hit the following issue (screencap):

<img width="964" alt="Screen Shot 2021-11-10 at 12 57 41 PM" src="https://user-images.githubusercontent.com/2515575/141226775-08e5e1d3-618c-4fae-a133-70685c7b3ad2.png">

This just updates the call there to pass `res`, which matches the signature documented here: https://auth0.github.io/nextjs-auth0/modules/session_get_session.html

With this fix, the rest of the example worked wonderfully 👍.

## Bug

- [x] Related issues linked using `fixes #number`
- [ ] Integration tests added (NA?)
- [x] Errors have helpful link attached, see `contributing.md`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue was opened via the bug report template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Auth0 Example stevejarvis/next.js
2 participants
@stevejarvis @balazsorban44