Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/second-locale-in-pathname remove console.log #31289

Merged
merged 4 commits into from Nov 11, 2021
Merged

bugfix/second-locale-in-pathname remove console.log #31289

merged 4 commits into from Nov 11, 2021

Conversation

vordgi
Copy link
Contributor

@vordgi vordgi commented Nov 11, 2021

Sorry, I forgot to remove console.log in a test

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 11, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname_2 Change
buildDuration 23.9s 23.4s -478ms
buildDurationCached 4.7s 4.9s ⚠️ +171ms
nodeModulesSize 335 MB 335 MB ⚠️ +12 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname_2 Change
/ failed reqs 0 0
/ total time (seconds) 4.007 4.018 ⚠️ +0.01
/ avg req/sec 623.9 622.24 ⚠️ -1.66
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.16 2.178 ⚠️ +0.02
/error-in-render avg req/sec 1157.19 1148.04 ⚠️ -9.15
Client Bundles (main, webpack, commons)
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname_2 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname_2 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname_2 Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname_2 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname_2 Change
index.html gzip 522 B 522 B
link.html gzip 535 B 535 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname_2 Change
buildDuration 25.7s 25.4s -294ms
buildDurationCached 5s 4.7s -213ms
nodeModulesSize 335 MB 335 MB ⚠️ +12 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname_2 Change
/ failed reqs 0 0
/ total time (seconds) 3.922 3.978 ⚠️ +0.06
/ avg req/sec 637.36 628.43 ⚠️ -8.93
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.997 2.06 ⚠️ +0.06
/error-in-render avg req/sec 1252.17 1213.58 ⚠️ -38.59
Client Bundles (main, webpack, commons)
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname_2 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname_2 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname_2 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname_2 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname_2 Change
index.html gzip 522 B 522 B
link.html gzip 534 B 534 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB
Commit: 5996cef

@kodiakhq kodiakhq bot merged commit 0c04f96 into vercel:canary Nov 11, 2021
@vordgi vordgi deleted the bugfix/second-locale-in-pathname_2 branch November 29, 2021 18:36
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants